Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1437190

Re: [PATCH v2] sched/deadline: remove useless param from setup_new_dl_entity

Show all headers | View raw

On Tue, 5 Jul 2016 15:39:33 +0100
Juri Lelli <juri.lelli@arm.com> wrote:

		return;
> > >  
> > >  	/*
> > > +	 * Use the scheduling parameters of the top pi-waiter task,
> > > +	 * if we have one from which we can inherit a deadline.
> > > +	 */
> > > +	if (pi_task && dl_se->dl_boosted && dl_prio(pi_task->normal_prio))
> > > +		pi_se = &pi_task->dl;
> > > +  
> > 
> > OK, I'm micro-optimizing now, but hey, isn't this a fast path?
> > 
> > What about changing the above to:
> > 
> > 	struct task_struct *pi_task;
> > 	[...]
> > 
> > 	if (dl_se->dl_boosted && dl_prio(pi_task->normal_prio &&  
>                                     ^
> OK, we need to reorder these two
>                                     V
> > 	    (pi_task = rt_mutex_get_top_task(dl_task_of(dl_se)))
> > 		pe_se = &pi_task->dl;

Opps, you're right.

> > 
> > This way we don't need to do any work of looking at
> > rt_mutex_get_top_task() for the normal case.
> >   
> 
> But, yes. Looks good to me. I'll shoot a v3 ASAP.

I have to ask, should there be any check if the dl_se has a shorter
deadline than the pi one?

-- Steve

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] sched/deadline: remove useless param from setup_new_dl_entity Juri Lelli <juri.lelli@arm.com> - 2016-06-29 21:10 +0200
  Re: [PATCH v2] sched/deadline: remove useless param from  setup_new_dl_entity luca abeni <luca.abeni@unitn.it> - 2016-07-04 11:10 +0200
    Re: [PATCH v2] sched/deadline: remove useless param from  setup_new_dl_entity Juri Lelli <juri.lelli@arm.com> - 2016-07-04 11:30 +0200
  Re: [PATCH v2] sched/deadline: remove useless param from setup_new_dl_entity Wanpeng Li <kernellwp@gmail.com> - 2016-07-05 09:40 +0200
    Re: [PATCH v2] sched/deadline: remove useless param from  setup_new_dl_entity Juri Lelli <juri.lelli@arm.com> - 2016-07-05 11:00 +0200
  Re: [PATCH v2] sched/deadline: remove useless param from  setup_new_dl_entity Steven Rostedt <rostedt@goodmis.org> - 2016-07-05 16:30 +0200
    Re: [PATCH v2] sched/deadline: remove useless param from  setup_new_dl_entity Juri Lelli <juri.lelli@arm.com> - 2016-07-05 16:40 +0200
      Re: [PATCH v2] sched/deadline: remove useless param from  setup_new_dl_entity Steven Rostedt <rostedt@goodmis.org> - 2016-07-05 18:50 +0200
        Re: [PATCH v2] sched/deadline: remove useless param from  setup_new_dl_entity Juri Lelli <juri.lelli@arm.com> - 2016-07-05 19:00 +0200
          Re: [PATCH v2] sched/deadline: remove useless param from  setup_new_dl_entity luca abeni <luca.abeni@unitn.it> - 2016-07-06 10:50 +0200
            Re: [PATCH v2] sched/deadline: remove useless param from  setup_new_dl_entity Juri Lelli <juri.lelli@arm.com> - 2016-07-07 10:40 +0200
              Re: [PATCH v2] sched/deadline: remove useless param from  setup_new_dl_entity Steven Rostedt <rostedt@goodmis.org> - 2016-07-07 15:50 +0200
                Re: [PATCH v2] sched/deadline: remove useless param from  setup_new_dl_entity Juri Lelli <juri.lelli@arm.com> - 2016-07-08 13:40 +0200
    Re: [PATCH v2] sched/deadline: remove useless param from  setup_new_dl_entity luca abeni <luca.abeni@unitn.it> - 2016-07-06 10:50 +0200

csiph-web