Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1435959
| Path | csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Jonathan Cameron <jic23@kernel.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/2] input: adc-keys: add DT binding documentation |
| Date | Sun, 03 Jul 2016 15:50:01 +0200 |
| Message-ID | <rQPWx-Ru-9@gated-at.bofh.it> (permalink) |
| References | <rQekh-3jb-7@gated-at.bofh.it> |
| X-Original-To | Alexandre Belloni <alexandre.belloni@free-electrons.com>, Dmitry Torokhov <dmitry.torokhov@gmail.com> |
| User-Agent | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=windows-1252 |
| Content-Transfer-Encoding | 7bit |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 68 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Maxime Ripard <maxime.ripard@free-electrons.com>, linux-input@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org |
| X-Original-Date | Sun, 3 Jul 2016 14:43:56 +0100 |
| X-Original-Message-ID | <5d71d3a2-4d51-8dd5-0e4a-638ec1b5035a@kernel.org> |
| X-Original-References | <1467408602-16546-1-git-send-email-alexandre.belloni@free-electrons.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1435959 |
Show key headers only | View raw
On 01/07/16 22:30, Alexandre Belloni wrote:
> Add documentation for ADC keys
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Clean looking binding to me - one comment inline.
Jonathan
> ---
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
>
> .../devicetree/bindings/input/adc-keys.txt | 45 ++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/adc-keys.txt
>
> diff --git a/Documentation/devicetree/bindings/input/adc-keys.txt b/Documentation/devicetree/bindings/input/adc-keys.txt
> new file mode 100644
> index 000000000000..873476bb4eab
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/adc-keys.txt
> @@ -0,0 +1,45 @@
> +Allwinner sun4i low res adc attached tablet keys
What is allwinner specific in here? Looks pretty general purpose to me!
> +------------------------------------------------
> +
> +Required properties:
> + - compatible: "adc-keys"
> + - io-channels: Phandle to an ADC channel
> + - io-channel-names = "buttons";
> + - voltage-keyup-mvolt: Voltage at which all the keys are considered up.
> +
> +Each key is represented as a sub-node of "adc-keys":
> +
> +Required subnode-properties:
> + - label: Descriptive name of the key.
> + - linux,code: Keycode to emit.
> + - voltage-mvolt: Voltage adc input when this key is pressed.
> +
> +Example:
> +
> +#include <dt-bindings/input/input.h>
> +
> + adc-keys {
> + compatible = "adc-keys";
> + io-channels = <&lradc 0>;
> + io-channel-names = "buttons";
> + voltage-keyup-mvolt = <2000>;
> +
> + button@1500 {
> + label = "Volume Up";
> + linux,code = <KEY_VOLUMEUP>;
> + voltage-mvolt = <1500>;
> + };
> +
> + button@1000 {
> + label = "Volume Down";
> + linux,code = <KEY_VOLUMEDOWN>;
> + voltage-mvolt = <1000>;
> + };
> +
> + button@500 {
> + label = "Enter";
> + linux,code = <KEY_ENTER>;
> + voltage-mvolt = <500>;
> + };
> + };
> +
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/2] input: adc-keys: add DT binding documentation Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-07-01 23:40 +0200
[PATCH 2/2] input: add ADC resistor ladder driver Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-07-01 23:40 +0200
Re: [PATCH 2/2] input: add ADC resistor ladder driver Matt Ranostay <mranostay@gmail.com> - 2016-07-03 00:30 +0200
Re: [PATCH 2/2] input: add ADC resistor ladder driver Jonathan Cameron <jic23@kernel.org> - 2016-07-03 16:00 +0200
Re: [PATCH 1/2] input: adc-keys: add DT binding documentation Jonathan Cameron <jic23@kernel.org> - 2016-07-03 15:50 +0200
Re: [PATCH 1/2] input: adc-keys: add DT binding documentation Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-07-04 18:30 +0200
Re: [PATCH 1/2] input: adc-keys: add DT binding documentation Rob Herring <robh@kernel.org> - 2016-07-05 17:00 +0200
csiph-web