Re: [PATCH 1/2] input: adc-keys: add DT binding documentation

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] input: adc-keys: add DT binding documentation
Date	2016-07-05 17:00 +0200
Message-ID	<rRzZn-4bX-19@gated-at.bofh.it> (permalink)
References	<rQekh-3jb-7@gated-at.bofh.it> <rQPWx-Ru-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Jul 03, 2016 at 02:43:56PM +0100, Jonathan Cameron wrote:
> On 01/07/16 22:30, Alexandre Belloni wrote:
> > Add documentation for ADC keys
> > 
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Clean looking binding to me - one comment inline.
> 
> Jonathan
> > ---
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: devicetree@vger.kernel.org
> > 
> >  .../devicetree/bindings/input/adc-keys.txt         | 45 ++++++++++++++++++++++
> >  1 file changed, 45 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/input/adc-keys.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/input/adc-keys.txt b/Documentation/devicetree/bindings/input/adc-keys.txt
> > new file mode 100644
> > index 000000000000..873476bb4eab
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/input/adc-keys.txt
> > @@ -0,0 +1,45 @@
> > +Allwinner sun4i low res adc attached tablet keys
> What is allwinner specific in here?  Looks pretty general purpose to me!
> > +------------------------------------------------
> > +
> > +Required properties:
> > + - compatible: "adc-keys"
> > + - io-channels: Phandle to an ADC channel
> > + - io-channel-names = "buttons";
> > + - voltage-keyup-mvolt: Voltage at which all the keys are considered up.
> > +
> > +Each key is represented as a sub-node of "adc-keys":
> > +
> > +Required subnode-properties:
> > +	- label: Descriptive name of the key.
> > +	- linux,code: Keycode to emit.
> > +	- voltage-mvolt: Voltage adc input when this key is pressed.

voltage-mcvoltface?

"voltage" is redundant and use standard units. How about 
{press,up}-threshold-microvolt?

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] input: adc-keys: add DT binding documentation Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-07-01 23:40 +0200
  [PATCH 2/2] input: add ADC resistor ladder driver Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-07-01 23:40 +0200
    Re: [PATCH 2/2] input: add ADC resistor ladder driver Matt Ranostay <mranostay@gmail.com> - 2016-07-03 00:30 +0200
    Re: [PATCH 2/2] input: add ADC resistor ladder driver Jonathan Cameron <jic23@kernel.org> - 2016-07-03 16:00 +0200
  Re: [PATCH 1/2] input: adc-keys: add DT binding documentation Jonathan Cameron <jic23@kernel.org> - 2016-07-03 15:50 +0200
    Re: [PATCH 1/2] input: adc-keys: add DT binding documentation Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-07-04 18:30 +0200
    Re: [PATCH 1/2] input: adc-keys: add DT binding documentation Rob Herring <robh@kernel.org> - 2016-07-05 17:00 +0200

csiph-web