Re: [PATCH net-next 9/9] net: hns: get reset registers from DT

Path	csiph.com!goblin2!goblin1!goblin.stu.neva.ru!nntpspool.opticnetworks.net!nntpspool01.opticnetworks.net!aioe.org!bofh.it!news.nic.it!robomod
From	"Yankejian (Hackim Yim)" <yankejian@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next 9/9] net: hns: get reset registers from DT
Date	Thu, 30 Jun 2016 03:20:02 +0200
Message-ID	<rPyO6-35Z-5@gated-at.bofh.it> (permalink)
References	<rOBbj-6NY-3@gated-at.bofh.it> <rOBbj-6NY-9@gated-at.bofh.it> <rPjP3-2kI-17@gated-at.bofh.it>
X-Original-To	David Miller <davem@davemloft.net>, <Yisen.Zhuang@huawei.com>
User-Agent	Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1
MIME-Version	1.0
Content-Type	text/plain; charset="windows-1252"
Content-Transfer-Encoding	7bit
X-Originating-IP	[10.57.126.191]
X-Cfilter-Loop	Reflected
X-Mirapoint-Virus-Rapid-Raw	score=unknown(0), refid=str=0001.0A090205.577471AB.00AB,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-ID	617592a37b047987a5e795fdcf941e35
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	31
Organization	linux.* mail to news gateway
X-Original-Cc	<salil.mehta@huawei.com>, <liguozhu@huawei.com>, <huangdaode@hisilicon.com>, <arnd@arndb.de>, <andriy.shevchenko@linux.intel.com>, <andrew@lunn.ch>, <geliangtang@163.com>, <ivecera@redhat.com>, <fengguang.wu@intel.com>, <charles.chenxin@huawei.com>, <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linuxarm@huawei.com>
X-Original-Date	Thu, 30 Jun 2016 09:10:52 +0800
X-Original-Message-ID	<5774719C.4090409@huawei.com>
X-Original-References	<1467021255-95900-1-git-send-email-Yisen.Zhuang@huawei.com> <1467021255-95900-10-git-send-email-Yisen.Zhuang@huawei.com> <20160629.051142.259737654994822294.davem@davemloft.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1434138

Show key headers only | View raw

On 2016/6/29 17:11, David Miller wrote:
> From: Yisen Zhuang <Yisen.Zhuang@huawei.com>
> Date: Mon, 27 Jun 2016 17:54:15 +0800
>
>> @@ -361,9 +371,10 @@ static int hns_mdio_reset(struct mii_bus *bus)
>>  			return -ENODEV;
>>  		}
>>  
>> +	sc_reg = &mdio_dev->sc_reg;
>>  		/* 1. reset req, and read reset st check */
>> -		ret = mdio_sc_cfg_reg_write(mdio_dev, MDIO_SC_RESET_REQ, 0x1,
>> -					    MDIO_SC_RESET_ST, 0x1,
>> +	ret = mdio_sc_cfg_reg_write(mdio_dev, sc_reg->mdio_reset_req, 0x1,
>> +				    sc_reg->mdio_reset_st, 0x1,
>>  					    MDIO_CHECK_SET_ST);
>>  		if (ret) {
>>  			dev_err(&bus->dev, "MDIO reset fail\n");
> What in the world are you doing to the indentation here?
>
> Please read your patches before actually sending them, such things
> will be quite obvious by simple visual inspection.
>
> .
>
Hi David,
i am sorry for my carelessness. i will pay more attention next time.
Thanks for pointing it our

-- 
MBR,
Yankejian (Hackim Yim)

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next 9/9] net: hns: get reset registers from DT Yisen Zhuang <Yisen.Zhuang@huawei.com> - 2016-06-27 11:40 +0200
  Re: [PATCH net-next 9/9] net: hns: get reset registers from DT David Miller <davem@davemloft.net> - 2016-06-29 11:20 +0200
    Re: [PATCH net-next 9/9] net: hns: get reset registers from DT "Yankejian (Hackim Yim)" <yankejian@huawei.com> - 2016-06-30 03:20 +0200

csiph-web