Re: [PATCH net-next 9/9] net: hns: get reset registers from DT

From	"Yankejian (Hackim Yim)" <yankejian@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next 9/9] net: hns: get reset registers from DT
Date	2016-06-30 03:20 +0200
Message-ID	<rPyO6-35Z-5@gated-at.bofh.it> (permalink)
References	<rOBbj-6NY-3@gated-at.bofh.it> <rOBbj-6NY-9@gated-at.bofh.it> <rPjP3-2kI-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2016/6/29 17:11, David Miller wrote:
> From: Yisen Zhuang <Yisen.Zhuang@huawei.com>
> Date: Mon, 27 Jun 2016 17:54:15 +0800
>
>> @@ -361,9 +371,10 @@ static int hns_mdio_reset(struct mii_bus *bus)
>>  			return -ENODEV;
>>  		}
>>  
>> +	sc_reg = &mdio_dev->sc_reg;
>>  		/* 1. reset req, and read reset st check */
>> -		ret = mdio_sc_cfg_reg_write(mdio_dev, MDIO_SC_RESET_REQ, 0x1,
>> -					    MDIO_SC_RESET_ST, 0x1,
>> +	ret = mdio_sc_cfg_reg_write(mdio_dev, sc_reg->mdio_reset_req, 0x1,
>> +				    sc_reg->mdio_reset_st, 0x1,
>>  					    MDIO_CHECK_SET_ST);
>>  		if (ret) {
>>  			dev_err(&bus->dev, "MDIO reset fail\n");
> What in the world are you doing to the indentation here?
>
> Please read your patches before actually sending them, such things
> will be quite obvious by simple visual inspection.
>
> .
>
Hi David,
i am sorry for my carelessness. i will pay more attention next time.
Thanks for pointing it our

-- 
MBR,
Yankejian (Hackim Yim)

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next 9/9] net: hns: get reset registers from DT Yisen Zhuang <Yisen.Zhuang@huawei.com> - 2016-06-27 11:40 +0200
  Re: [PATCH net-next 9/9] net: hns: get reset registers from DT David Miller <davem@davemloft.net> - 2016-06-29 11:20 +0200
    Re: [PATCH net-next 9/9] net: hns: get reset registers from DT "Yankejian (Hackim Yim)" <yankejian@huawei.com> - 2016-06-30 03:20 +0200

csiph-web