Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1434006

Re: [Cocci] [PATCH] Coccinelle: Script to replace NULL test with IS_ERR test for devm_ioremap_resource

From Wolfram Sang <wsa@the-dreams.de>
Newsgroups linux.kernel
Subject Re: [Cocci] [PATCH] Coccinelle: Script to replace NULL test with IS_ERR test for devm_ioremap_resource
Date 2016-06-29 21:30 +0200
Message-ID <rPtlo-8bY-13@gated-at.bofh.it> (permalink)
References <rPsyZ-7FB-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Thu, Jun 30, 2016 at 12:03:47AM +0530, Amitoj Kaur Chawla wrote:
> This script detects cases which have incorrect error handling for
> devm_ioremap_resource function, employing a NULL test instead of an
> IS_ERR() test.
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>

Why don't we fix the code at the same time?

And it should not be restricted to devm_ioremap_resource() but
extensible so other functions could be added later?

(Surprised to see that we don't have such a script yet)

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] Coccinelle: Script to replace NULL test with IS_ERR test for  devm_ioremap_resource Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-06-29 20:40 +0200
  Re: [Cocci] [PATCH] Coccinelle: Script to replace NULL test with  IS_ERR test for devm_ioremap_resource Wolfram Sang <wsa@the-dreams.de> - 2016-06-29 21:30 +0200
    Re: [Cocci] [PATCH] Coccinelle: Script to replace NULL test with  IS_ERR test for devm_ioremap_resource Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-06-30 04:50 +0200
      Re: [Cocci] [PATCH] Coccinelle: Script to replace NULL test with  IS_ERR test for devm_ioremap_resource Wolfram Sang <wsa@the-dreams.de> - 2016-06-30 09:20 +0200

csiph-web