Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1434005

Re: [PATCH] mmotm: mm-oom-fortify-task_will_free_mem-fix

From Oleg Nesterov <oleg@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH] mmotm: mm-oom-fortify-task_will_free_mem-fix
Date 2016-06-29 21:30 +0200
Message-ID <rPtln-8bY-3@gated-at.bofh.it> (permalink)
References <rPmjT-3IF-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 06/29, Michal Hocko wrote:
>
> But it seems that further changes I am
> planning in this area will benefit from stable task->mm in this path

Oh, so I hope you will cleanup this later,

> Just pull the task->mm !=
> NULL check inside the function.

OK, but this means it will always return false if the task is a zombie
leader.

I am not really arguing and this is not that bad, but this doesn't look
nice and imo asks for cleanup.

Oleg.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] mmotm: mm-oom-fortify-task_will_free_mem-fix Michal Hocko <mhocko@kernel.org> - 2016-06-29 14:00 +0200
  Re: [PATCH] mmotm: mm-oom-fortify-task_will_free_mem-fix Oleg Nesterov <oleg@redhat.com> - 2016-06-29 21:30 +0200
    Re: [PATCH] mmotm: mm-oom-fortify-task_will_free_mem-fix Michal Hocko <mhocko@kernel.org> - 2016-06-30 10:30 +0200

csiph-web