Re: [PATCH] mac80211: rx: frames received out of order

From	Johannes Berg <johannes@sipsolutions.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mac80211: rx: frames received out of order
Date	2016-06-29 09:20 +0200
Message-ID	<rPhWV-1co-21@gated-at.bofh.it> (permalink)
References	<rOZdD-6hk-13@gated-at.bofh.it> <rPhWV-1co-23@gated-at.bofh.it> <rOZdD-6hk-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 2016-06-28 at 14:15 +0300, Yaniv Machani wrote:
> From: Meirav Kama <meiravk@ti.com>
> 
> MP received data frames from another MP. Frames are forwarded
> from Rx to Tx to be transmitted to a third MP.
> Upon cloning the skb, the tx_info was zeroed, and the
> hw_queue wasn't set correctly, causing frames to be
> inserted to queue 0 (VOICE). If re-queue occurred for some
> reason, frame will be inserted to correct queue 2 (BE).
> In this case frames are now dequeued from 2 different queues and
> sent out of order.

Please rewrite this commit log in active voice, and explain the fix
too.

> Signed-off-by: Meirav Kama <meiravk@ti.com>
> Acked-by: Yaniv Machani <yanivma@ti.com>

See Julian's comment.

johannes

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mac80211: rx: frames received out of order Yaniv Machani <yanivma@ti.com> - 2016-06-28 13:20 +0200
  Re: [PATCH] mac80211: rx: frames received out of order Johannes Berg <johannes@sipsolutions.net> - 2016-06-29 09:20 +0200

csiph-web