Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1433502

Re: [PATCH 1/4] mac80211: mesh: flush stations before beacons are stopped

Show all headers | View raw

On Tue, 2016-06-28 at 14:13 +0300, Yaniv Machani wrote:
> From: Maital Hahn <maitalm@ti.com>
> 
> Some drivers (e.g. wl18xx) expect that the last stage in the
> de-initialization process will be stopping the beacons, similar to
> ap. Update ieee80211_stop_mesh() flow accordingly.
> 
How well have you tested that with other drivers?

Changing behaviour to something a single driver desires isn't
necessarily the best thing to do, since there always are multiple
drivers.

If you're able to demonstrate that it works with the other drivers I'm
willing to take that - the change makes sense after all, and it seems
drivers must support this ordering since peers are also removed
dynamically... But still. Don't just make a change like that without
even giving any indication why you think it's fine for other drivers!

johannes

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] mac80211: mesh: flush stations before beacons are stopped Yaniv Machani <yanivma@ti.com> - 2016-06-28 13:20 +0200
  [PATCH 2/4] mac80211/cfg: mesh: fix healing time when a mesh peer is disconnecting Yaniv Machani <yanivma@ti.com> - 2016-06-28 13:20 +0200
    Re: [PATCH 2/4] mac80211/cfg: mesh: fix healing time when a mesh  peer is disconnecting Bob Copeland <me@bobcopeland.com> - 2016-06-28 14:30 +0200
      RE: [PATCH 2/4] mac80211/cfg: mesh: fix healing time when a mesh  peer is disconnecting "Machani, Yaniv" <yanivma@ti.com> - 2016-06-28 16:50 +0200
  Re: [PATCH 1/4] mac80211: mesh: flush stations before beacons are  stopped Johannes Berg <johannes@sipsolutions.net> - 2016-06-29 09:20 +0200

csiph-web