Re: [PATCH] platform/x86: Add IIO dependency to ACPI_TOSHIBA

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Azael Avalos <coproscefalo@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] platform/x86: Add IIO dependency to ACPI_TOSHIBA
Date	Wed, 29 Jun 2016 07:30:01 +0200
Message-ID	<rPget-8vr-1@gated-at.bofh.it> (permalink)
References	<rP7kR-2R4-15@gated-at.bofh.it> <rPg4O-8s8-13@gated-at.bofh.it>
X-Original-To	Darren Hart <dvhart@infradead.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=CCAZkWi6ClRnY7A6HpVqc6fxMVeY1+kAJBGvwMUqKJg=; b=PKdzknnPjIBa7KGOJrXImzL5t6hPdUvWAEK5Nn0BNSusk/mtblj+qBc4puJBfU3e+X xP5GF7eSnohwYr6QSTjvOWNJX+dkxLTBs1MpPsaRFd7zjdeS0RCUQNDTSL5r2FfC98Gs 9A00QH5k4ES/MNN8KcxcpovzQiMNVGmQWLpi1wSxFTbQ4BAIKeo4a4Ke56vQV7y0BGt1 xt+0aYtESR5KmobjTbLnKfuEG0uaigjvzYX1meGYHqLXWAubSVm20rmlwIVAFWh6PFVJ VaPFDK6yut4gVNsygYbpMqAYeoCFvyyVdCufbIZK1XeNvtibixh0ds1jerfP5PzAb0Wk VEWw==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=CCAZkWi6ClRnY7A6HpVqc6fxMVeY1+kAJBGvwMUqKJg=; b=aSuZQhOeMWh0ut+wp7QvRoeNM67RaACTrrFlJTDCx9c+6W+Z34mdMkcuHzgISM/j9k YXttVz/pMofV6d/RbswaX7QL4JvTG6vvgjx9b4LbGGCRhK3obNJ9Oaf9Q5nGYlRL4qTG LNGF0vvb8U7wXKtkLGA9wcMAWPcBlG03tDSCjHDgYn6rNWHFT4fWppSVfASErrg7t3T6 qX62gXgIqaV6zOOovo6DDSWYv21UxrjZqv6px5fKL8kVDiUi1KKMI9RQRmlieeGz5a80 O5n7ED1rOeO/xdif/tHJg3P19VszvjCICsw0qxiNqUxdrKGq7D0xYI+uSW44UiZqFvmH Mp3g==
X-Gm-Message-State	ALyK8tLdpWuE2/ny3jAXAu4rr66CTQ9I1kOij4YSCo33i6UJ0AvC2P/795ZuNBsq7BCOA1L8Gg0+u3GCETr7vA==
X-Received	by 10.157.32.166 with SMTP id x35mr4322186ota.32.1467177700617; Tue, 28 Jun 2016 22:21:40 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	60
Organization	linux.* mail to news gateway
X-Original-Cc	Jonathan Cameron <jic23@kernel.org>, "platform-driver-x86@vger.kernel.org" <platform-driver-x86@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
X-Original-Date	Tue, 28 Jun 2016 23:21:39 -0600
X-Original-Message-ID	<CAGdLNWGPP1HsfCFP8GKUDR1_c1+yZ5BY_NPqfj4_6wvh+xOL1Q@mail.gmail.com>
X-Original-References	<20160628195855.22199-1-coproscefalo@gmail.com> <20160629051634.GM3837@f23x64.localdomain>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1433453

Show key headers only | View raw

2016-06-28 23:16 GMT-06:00 Darren Hart <dvhart@infradead.org>:
> On Tue, Jun 28, 2016 at 01:58:55PM -0600, Azael Avalos wrote:
>> The toshiba_acpi driver added support to the accelerometer axis
>> via the IIO subsystem, but failed to add the dependency to the
>> Kconfig file, making the driver fail to compile if the IIO
>> subsystem is not selected.
>>
>> This patch adds a depedency to the IIO subsystem to the
>> ACPI_TOSHIBA entry in Kconfig to avoid such build failure.
>>
>> Signed-off-by: Azael Avalos <coproscefalo@gmail.com>
>> ---
>> Darren, Jonathan:
>>  I just received a few mails from the kbuild test robot informing
>>  the build failure, as a fix for this I just added a hard dependency
>>  to IIO, but maybe Jonathan can weigh in and provide me with a better
>>  alternative (perhaps some ifdefs) as to the hard IIO dependency.
>
> Don't you just love the giant kernel builder in the sky?

I certainly do, the ever watching eye XD

>
> Rather than add this separately and leave a potential build failure in the
> kernel, I'll add this line to:
>
> toshiba_acpi: Add IIO interface for accelerometer axis data

Great :-)

>
>>
>>  drivers/platform/x86/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
>> index c06bb85..633fc5c 100644
>> --- a/drivers/platform/x86/Kconfig
>> +++ b/drivers/platform/x86/Kconfig
>> @@ -669,6 +669,7 @@ config ACPI_TOSHIBA
>>       depends on SERIO_I8042 || SERIO_I8042 = n
>>       depends on ACPI_VIDEO || ACPI_VIDEO = n
>>       depends on RFKILL || RFKILL = n
>> +     depends on IIO
>>       select INPUT_POLLDEV
>>       select INPUT_SPARSEKMAP
>>       ---help---
>> --
>> 2.8.4
>>
>>
>
> --
> Darren Hart
> Intel Open Source Technology Center



-- 
-- El mundo apesta y vosotros apestais tambien --

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] platform/x86: Add IIO dependency to ACPI_TOSHIBA Azael Avalos <coproscefalo@gmail.com> - 2016-06-28 22:00 +0200
  Re: [PATCH] platform/x86: Add IIO dependency to ACPI_TOSHIBA Darren Hart <dvhart@infradead.org> - 2016-06-29 07:20 +0200
    Re: [PATCH] platform/x86: Add IIO dependency to ACPI_TOSHIBA Azael Avalos <coproscefalo@gmail.com> - 2016-06-29 07:30 +0200

csiph-web