Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1433452

Re: [PATCH] platform/x86: Add IIO dependency to ACPI_TOSHIBA

Show all headers | View raw

On Tue, Jun 28, 2016 at 01:58:55PM -0600, Azael Avalos wrote:
> The toshiba_acpi driver added support to the accelerometer axis
> via the IIO subsystem, but failed to add the dependency to the
> Kconfig file, making the driver fail to compile if the IIO
> subsystem is not selected.
> 
> This patch adds a depedency to the IIO subsystem to the
> ACPI_TOSHIBA entry in Kconfig to avoid such build failure.
> 
> Signed-off-by: Azael Avalos <coproscefalo@gmail.com>
> ---
> Darren, Jonathan:
>  I just received a few mails from the kbuild test robot informing
>  the build failure, as a fix for this I just added a hard dependency
>  to IIO, but maybe Jonathan can weigh in and provide me with a better
>  alternative (perhaps some ifdefs) as to the hard IIO dependency.

Don't you just love the giant kernel builder in the sky?

Rather than add this separately and leave a potential build failure in the
kernel, I'll add this line to:

toshiba_acpi: Add IIO interface for accelerometer axis data

> 
>  drivers/platform/x86/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index c06bb85..633fc5c 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -669,6 +669,7 @@ config ACPI_TOSHIBA
>  	depends on SERIO_I8042 || SERIO_I8042 = n
>  	depends on ACPI_VIDEO || ACPI_VIDEO = n
>  	depends on RFKILL || RFKILL = n
> +	depends on IIO
>  	select INPUT_POLLDEV
>  	select INPUT_SPARSEKMAP
>  	---help---
> -- 
> 2.8.4
> 
> 

-- 
Darren Hart
Intel Open Source Technology Center

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] platform/x86: Add IIO dependency to ACPI_TOSHIBA Azael Avalos <coproscefalo@gmail.com> - 2016-06-28 22:00 +0200
  Re: [PATCH] platform/x86: Add IIO dependency to ACPI_TOSHIBA Darren Hart <dvhart@infradead.org> - 2016-06-29 07:20 +0200
    Re: [PATCH] platform/x86: Add IIO dependency to ACPI_TOSHIBA Azael Avalos <coproscefalo@gmail.com> - 2016-06-29 07:30 +0200

csiph-web