Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1433327

Re: [PATCH v2] clk: fixed-factor: add optional dt-binding clock-flags

From Michael Turquette <mturquette@baylibre.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2] clk: fixed-factor: add optional dt-binding clock-flags
Date 2016-06-28 23:20 +0200
Message-ID <rP8Ah-3MT-5@gated-at.bofh.it> (permalink)
References <rMicN-72i-11@gated-at.bofh.it> <rNqKZ-3iw-3@gated-at.bofh.it> <rP8gV-3r9-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Quoting Rob Herring (2016-06-28 13:55:18)
> On Fri, Jun 24, 2016 at 01:12:52PM +0900, Jongsung Kim wrote:
> > There is no way to set additional flags for a DT-initialized fixed-
> > factor-clock, and it can be problematic i.e., when the clock rate
> > needs to be changed. [1][2]
> > 
> > This patch introduces an optional dt-binding named "clock-flags" to
> > be used for passing any needed flags from dts.
> 
> I don't think we want this in DT. If we did, the flags would need some 
> documentation about what the flags mean.

Flags are specific to Linux implementation, so I agree with Rob. Better
to create a compatible string for your hardware that bakes in the flags.

Regards,
Mike

> 
> Rob

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] clk: fixed-factor: add optional dt-binding clock-flags Jongsung Kim <neidhard.kim@lge.com> - 2016-06-24 06:20 +0200
  Re: [PATCH v2] clk: fixed-factor: add optional dt-binding clock-flags Rob Herring <robh@kernel.org> - 2016-06-28 23:00 +0200
    Re: [PATCH v2] clk: fixed-factor: add optional dt-binding clock-flags Michael Turquette <mturquette@baylibre.com> - 2016-06-28 23:20 +0200
      Re: [PATCH v2] clk: fixed-factor: add optional dt-binding clock-flags Jongsung Kim <neidhard.kim@lge.com> - 2016-06-29 09:30 +0200
        Re: [PATCH v2] clk: fixed-factor: add optional dt-binding clock-flags Stephen Boyd <sboyd@codeaurora.org> - 2016-07-02 02:30 +0200
          Re: [PATCH v2] clk: fixed-factor: add optional dt-binding clock-flags Jongsung Kim <neidhard.kim@lge.com> - 2016-07-04 03:50 +0200
    Re: [PATCH v2] clk: fixed-factor: add optional dt-binding clock-flags Jongsung Kim <neidhard.kim@lge.com> - 2016-06-29 07:10 +0200

csiph-web