Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1433256

Re: [PATCH] regulator: pwm: Fix regulator ramp delay for continuous mode

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Jun 28, 2016 at 12:31:19PM -0700, Doug Anderson wrote:

> In all seriousness, I think the design for usleep_range() is to try to
> batch up wakeups to allow longer periods of sleeping and to optimize
> power.  This you want to sleep as long as is allowable and then if you
> happen to wakeup for some other reason anyway then you process all the
> things whose minimum has passed.  IIRC it was trying to get back to
> the good old days of only having jiffies where everyone was
> synchronized on the tick and you could sleep till the next tick after
> all the work was done.  When you think of it this way then sleeping to
> the max makes sense.  ...but it also means that you need to be careful
> and really not set the max too high.

That's what I *thought* it was doing, but when I looked at the
implementation down to the hrtimer level it was explicitly saying it was
actively trying to deliver the maximum delay but might do less.  I'd
have expected that the implementation would check to see if there was a
wakeup scheduled in the range, piggybacking on the first one if so, and 
if there was nothing it'd go for the minimum (perhaps with a bit of
rounding).  Oh well.

> Of course, in practice I've found that often usleep_range() 99% of the
> time sleeps for the max.  That can lead to some very subtle bugs if
> your min sleep is not long enough (!).

Yup.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] regulator: pwm: Fix regulator ramp delay for continuous mode Douglas Anderson <dianders@chromium.org> - 2016-06-28 07:00 +0200
  Re: [PATCH] regulator: pwm: Fix regulator ramp delay for continuous  mode Caesar Wang <caesar.upstream@gmail.com> - 2016-06-28 12:40 +0200
  Re: [PATCH] regulator: pwm: Fix regulator ramp delay for continuous mode Brian Norris <briannorris@chromium.org> - 2016-06-28 18:10 +0200
  Re: [PATCH] regulator: pwm: Fix regulator ramp delay for continuous  mode Mark Brown <broonie@kernel.org> - 2016-06-28 21:00 +0200
    Re: [PATCH] regulator: pwm: Fix regulator ramp delay for continuous mode Doug Anderson <dianders@chromium.org> - 2016-06-28 21:40 +0200
  Re: [PATCH] regulator: pwm: Fix regulator ramp delay for continuous  mode Mark Brown <broonie@kernel.org> - 2016-06-28 21:00 +0200
    Re: [PATCH] regulator: pwm: Fix regulator ramp delay for continuous mode Doug Anderson <dianders@chromium.org> - 2016-06-28 21:40 +0200
      Re: [PATCH] regulator: pwm: Fix regulator ramp delay for continuous  mode Mark Brown <broonie@kernel.org> - 2016-06-28 22:00 +0200
  Re: [PATCH] regulator: pwm: Fix regulator ramp delay for continuous  mode Mark Brown <broonie@kernel.org> - 2016-07-01 10:10 +0200
    Re: [PATCH] regulator: pwm: Fix regulator ramp delay for continuous mode Doug Anderson <dianders@chromium.org> - 2016-07-01 22:30 +0200
      Re: [PATCH] regulator: pwm: Fix regulator ramp delay for continuous  mode Mark Brown <broonie@kernel.org> - 2016-07-02 10:10 +0200
        Re: [PATCH] regulator: pwm: Fix regulator ramp delay for continuous mode Doug Anderson <dianders@chromium.org> - 2016-07-06 20:40 +0200
          Re: [PATCH] regulator: pwm: Fix regulator ramp delay for continuous  mode Mark Brown <broonie@kernel.org> - 2016-07-07 10:20 +0200
      Re: [PATCH] regulator: pwm: Fix regulator ramp delay for continuous  mode Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-07-02 18:00 +0200
        Re: [PATCH] regulator: pwm: Fix regulator ramp delay for continuous  mode Mark Brown <broonie@kernel.org> - 2016-07-04 11:00 +0200
          Re: [PATCH] regulator: pwm: Fix regulator ramp delay for continuous  mode Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-07-04 11:10 +0200
            Re: [PATCH] regulator: pwm: Fix regulator ramp delay for continuous  mode Mark Brown <broonie@kernel.org> - 2016-07-04 11:20 +0200
              Re: [PATCH] regulator: pwm: Fix regulator ramp delay for continuous  mode Thierry Reding <thierry.reding@gmail.com> - 2016-07-08 18:50 +0200
  Re: [PATCH] regulator: pwm: Fix regulator ramp delay for continuous  mode Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-07-06 14:30 +0200
    Re: [PATCH] regulator: pwm: Fix regulator ramp delay for continuous mode Doug Anderson <dianders@chromium.org> - 2016-07-06 20:40 +0200
      Re: [PATCH] regulator: pwm: Fix regulator ramp delay for continuous  mode Mark Brown <broonie@kernel.org> - 2016-07-07 10:20 +0200
    Re: [PATCH] regulator: pwm: Fix regulator ramp delay for continuous  mode Mark Brown <broonie@kernel.org> - 2016-07-07 10:20 +0200

csiph-web