Re: Deleting child qdisc doesn't reset parent to default qdisc?

Path	csiph.com!news.mixmin.net!feeds.phibee-telecom.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Jiri Kosina <jikos@kernel.org>
Newsgroups	linux.kernel
Subject	Re: Deleting child qdisc doesn't reset parent to default qdisc?
Date	Tue, 28 Jun 2016 17:20:01 +0200
Message-ID	<rP2XT-kK-15@gated-at.bofh.it> (permalink)
References	<rnQKL-3gf-29@gated-at.bofh.it> <rnR48-3Fm-83@gated-at.bofh.it> <rnRdM-3Ro-31@gated-at.bofh.it> <rnS0b-4DT-27@gated-at.bofh.it> <rnTyX-5JF-39@gated-at.bofh.it> <robma-36m-15@gated-at.bofh.it> <rodnY-4BO-5@gated-at.bofh.it>
X-X-Sender	jkosina@pobox.suse.cz
User-Agent	Alpine 2.00 (LNX 1167 2008-08-23)
MIME-Version	1.0
Content-Type	TEXT/PLAIN; charset=US-ASCII
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	32
Organization	linux.* mail to news gateway
X-Original-Cc	Jamal Hadi Salim <jhs@mojatatu.com>, Phil Sutter <phil@nwl.cc>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 28 Jun 2016 17:19:13 +0200 (CEST)
X-Original-Message-ID	<alpine.LNX.2.00.1606281717140.6874@cbobk.fhfr.pm>
X-Original-References	<alpine.LNX.2.00.1604141638230.27368@cbobk.fhfr.pm> <1460646099.10638.44.camel@edumazet-glaptop3.roam.corp.google.com> <20160414151813.GE3715@orbyte.nwl.cc> <alpine.LNX.2.00.1604141807350.27368@cbobk.fhfr.pm> <1460656170.10638.61.camel@edumazet-glaptop3.roam.corp.google.com> <5710E1C1.2090209@mojatatu.com> <1460732328.10638.74.camel@edumazet-glaptop3.roam.corp.google.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1433056

Show key headers only | View raw

On Fri, 15 Apr 2016, Eric Dumazet wrote:

> > TBF is probably a bad example because it started life as a classless 
> > qdisc. There was only one built-in fifo queue that was shaped. Then 
> > someone made it classful and changed this behavior. To me it sounds 
> > reasonable to have the default behavior restored. At minimal 
> > consistency.
> 
> 
> Then you need to save the initial qdisc (bfifo for TBF) in a special
> place, to make sure the delete operation is guaranteed to succeed.
> 
> Or fail the delete if the bfifo can not be allocated.
> 
> I can tell that determinism if far more interesting than usability for
> some users occasionally playing with tc.

BTW, I've started to actually work on fixing this, and I've noticed that 
TBF behavior actually violates what's stated in pfifo_fast manpage:

==========
        Whenever  an  interface is created, the pfifo_fast qdisc is 
	automatically used as a queue. If another qdisc is
	attached, it preempts the default pfifo_fast, which automatically 
	returns to function when an  existing  qdisc is detached.

	In this sense this qdisc is magic, and unlike other qdiscs.
==========

-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: Deleting child qdisc doesn't reset parent to default qdisc? Jiri Kosina <jikos@kernel.org> - 2016-06-28 17:20 +0200
  Re: Deleting child qdisc doesn't reset parent to default qdisc? Cong Wang <xiyou.wangcong@gmail.com> - 2016-06-28 19:30 +0200
    Re: Deleting child qdisc doesn't reset parent to default qdisc? Jiri Kosina <jikos@kernel.org> - 2016-06-28 19:40 +0200

csiph-web