Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1431669
| From | Larry Finger <Larry.Finger@lwfinger.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] rtlwifi: Add missing newlines to RT_TRACE calls |
| Date | 2016-06-27 03:50 +0200 |
| Message-ID | <rOtQt-257-3@gated-at.bofh.it> (permalink) |
| References | <rOo4p-6Yf-1@gated-at.bofh.it> <rOsrn-1le-7@gated-at.bofh.it> <rOtns-1Tq-9@gated-at.bofh.it> <rOtx7-1WA-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 06/26/2016 08:26 PM, Joe Perches wrote: > On Sun, 2016-06-26 at 18:13 -0700, Joe Perches wrote: >> On Sun, 2016-06-26 at 19:18 -0500, Larry Finger wrote: >>> >>> On 06/26/2016 02:34 PM, Joe Perches wrote: >>>> >>>> >>>> RT_TRACE does not add a newline to the end of a message and always >>>> emits at KERN_DEBUG so these are susceptible to message >>>> interleaving >>>> from other processes without the newline. >>>> >>>> Signed-off-by: Joe Perches <joe@perches.com> >>>> --- >>> This patch does not apply to the wireless-drivers-next repo. Which >>> one >>> did you use? >> linux-next > > btw: both patches seem to apply to wireless-drivers-next just fine. > > $ git rev-parse HEAD > 1bb57c8a5e33bcbec031ce0c629968922d5af89d > $ git am ../next/0001-rtlwifi-Create-_rtl_dbg_trace-function-to-reduce-RT_.patch > Applying: rtlwifi: Create _rtl_dbg_trace function to reduce RT_TRACE code size > $ git am ../next/0001-rtlwifi-Add-missing-newlines-to-RT_TRACE-calls.patch > Applying: rtlwifi: Add missing newlines to RT_TRACE calls The conflict is with the set of 10 patches I sent out yesterday. As I have to update them anyway, I will apply yours first, then do mine. That should resolve the problem. Larry
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] rtlwifi: Add missing newlines to RT_TRACE calls Joe Perches <joe@perches.com> - 2016-06-26 21:40 +0200
Re: [PATCH] rtlwifi: Add missing newlines to RT_TRACE calls Larry Finger <Larry.Finger@lwfinger.net> - 2016-06-27 02:20 +0200
Re: [PATCH] rtlwifi: Add missing newlines to RT_TRACE calls Joe Perches <joe@perches.com> - 2016-06-27 03:20 +0200
Re: [PATCH] rtlwifi: Add missing newlines to RT_TRACE calls Joe Perches <joe@perches.com> - 2016-06-27 03:30 +0200
Re: [PATCH] rtlwifi: Add missing newlines to RT_TRACE calls Larry Finger <Larry.Finger@lwfinger.net> - 2016-06-27 03:50 +0200
Re: rtlwifi: Add missing newlines to RT_TRACE calls Kalle Valo <kvalo@codeaurora.org> - 2016-07-08 12:00 +0200
csiph-web