Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1432019

[tip:efi/core] efibc: Report more information in the error messages

Show all headers | View raw

Commit-ID:  5356c32742bd51c8c57065d2389a2c4bc036adcd
Gitweb:     http://git.kernel.org/tip/5356c32742bd51c8c57065d2389a2c4bc036adcd
Author:     Compostella, Jeremy <jeremy.compostella@intel.com>
AuthorDate: Sat, 25 Jun 2016 08:20:24 +0100
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 27 Jun 2016 13:06:54 +0200

efibc: Report more information in the error messages

Report the name of the EFI variable if the value size is too large,
or if efibc_set_variable() fails to allocate the 'struct efivar_entry'
object.

If efibc_set_variable() fails because the 'size' value is too
large, it also reports this value in the error message.

Reported-by: Robert Elliott <elliott@hpe.com>
Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com>
Signed-off-by: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-efi@vger.kernel.org
Link: http://lkml.kernel.org/r/1466839230-12781-2-git-send-email-matt@codeblueprint.co.uk
[ Minor readability edits. ]
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 drivers/firmware/efi/efibc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/efi/efibc.c b/drivers/firmware/efi/efibc.c
index 8dd0c70..503bbe2 100644
--- a/drivers/firmware/efi/efibc.c
+++ b/drivers/firmware/efi/efibc.c
@@ -37,13 +37,13 @@ static int efibc_set_variable(const char *name, const char *value)
 	size_t size = (strlen(value) + 1) * sizeof(efi_char16_t);
 
 	if (size > sizeof(entry->var.Data)) {
-		pr_err("value is too large");
+		pr_err("value is too large (%zu bytes) for '%s' EFI variable\n", size, name);
 		return -EINVAL;
 	}
 
 	entry = kmalloc(sizeof(*entry), GFP_KERNEL);
 	if (!entry) {
-		pr_err("failed to allocate efivar entry");
+		pr_err("failed to allocate efivar entry for '%s' EFI variable\n", name);
 		return -ENOMEM;
 	}
 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[GIT PULL 0/7] EFI changes for v4.8 Matt Fleming <matt@codeblueprint.co.uk> - 2016-06-25 09:30 +0200
  [PATCH 6/7] x86/efi: Update efi_thunk to use the the arch_efi_call_virt* macros Matt Fleming <matt@codeblueprint.co.uk> - 2016-06-25 09:30 +0200
    [tip:efi/core] x86/efi: Update efi_thunk() to use the the  arch_efi_call_virt*() macros tip-bot for Alex Thorlton <tipbot@zytor.com> - 2016-06-27 15:10 +0200
  [PATCH 1/7] efibc: Report more information in the error messages Matt Fleming <matt@codeblueprint.co.uk> - 2016-06-25 09:30 +0200
    [tip:efi/core] efibc: Report more information in the error messages "tip-bot for Compostella, Jeremy" <tipbot@zytor.com> - 2016-06-27 15:10 +0200
  [PATCH 4/7] efi: Convert efi_call_virt to efi_call_virt_pointer Matt Fleming <matt@codeblueprint.co.uk> - 2016-06-25 09:30 +0200
    Re: [PATCH 4/7] efi: Convert efi_call_virt to efi_call_virt_pointer Ingo Molnar <mingo@kernel.org> - 2016-06-27 13:10 +0200
      Re: [PATCH 4/7] efi: Convert efi_call_virt to efi_call_virt_pointer Mark Rutland <mark.rutland@arm.com> - 2016-06-27 13:30 +0200
      Re: [PATCH 4/7] efi: Convert efi_call_virt to efi_call_virt_pointer Matt Fleming <matt@codeblueprint.co.uk> - 2016-07-04 15:20 +0200
    [tip:efi/core] efi: Convert efi_call_virt() to  efi_call_virt_pointer() tip-bot for Alex Thorlton <tipbot@zytor.com> - 2016-06-27 15:10 +0200

csiph-web