Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1431926
| From | Ingo Molnar <mingo@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4/7] efi: Convert efi_call_virt to efi_call_virt_pointer |
| Date | 2016-06-27 13:10 +0200 |
| Message-ID | <rOCAq-7Tb-9@gated-at.bofh.it> (permalink) |
| References | <rNQcp-2yr-5@gated-at.bofh.it> <rNQcq-2yr-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
* Matt Fleming <matt@codeblueprint.co.uk> wrote:
> +#define efi_call_virt_pointer(p, f, args...) \
> +({ \
> + efi_status_t __s; \
> + unsigned long flags; \
> + \
> + arch_efi_call_virt_setup(); \
> + \
> + local_save_flags(flags); \
> + __s = arch_efi_call_virt(p, f, args); \
> + efi_call_virt_check_flags(flags, __stringify(f)); \
> + \
> + arch_efi_call_virt_teardown(); \
> + \
> + __s; \
> +})
> +
> +#define __efi_call_virt_pointer(p, f, args...) \
> +({ \
> + unsigned long flags; \
> + \
> + arch_efi_call_virt_setup(); \
> + \
> + local_save_flags(flags); \
> + arch_efi_call_virt(p, f, args); \
> + efi_call_virt_check_flags(flags, __stringify(f)); \
> + \
> + arch_efi_call_virt_teardown(); \
> +})
Note that while at it I renamed 'flags' to '__flags' because 'flags' is
a commonly used variable name and the 'efi_status_t __s' variable was
macro-prefixed already.
Any objections?
Thanks,
Ingo
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[GIT PULL 0/7] EFI changes for v4.8 Matt Fleming <matt@codeblueprint.co.uk> - 2016-06-25 09:30 +0200
[PATCH 6/7] x86/efi: Update efi_thunk to use the the arch_efi_call_virt* macros Matt Fleming <matt@codeblueprint.co.uk> - 2016-06-25 09:30 +0200
[tip:efi/core] x86/efi: Update efi_thunk() to use the the arch_efi_call_virt*() macros tip-bot for Alex Thorlton <tipbot@zytor.com> - 2016-06-27 15:10 +0200
[PATCH 1/7] efibc: Report more information in the error messages Matt Fleming <matt@codeblueprint.co.uk> - 2016-06-25 09:30 +0200
[tip:efi/core] efibc: Report more information in the error messages "tip-bot for Compostella, Jeremy" <tipbot@zytor.com> - 2016-06-27 15:10 +0200
[PATCH 4/7] efi: Convert efi_call_virt to efi_call_virt_pointer Matt Fleming <matt@codeblueprint.co.uk> - 2016-06-25 09:30 +0200
Re: [PATCH 4/7] efi: Convert efi_call_virt to efi_call_virt_pointer Ingo Molnar <mingo@kernel.org> - 2016-06-27 13:10 +0200
Re: [PATCH 4/7] efi: Convert efi_call_virt to efi_call_virt_pointer Mark Rutland <mark.rutland@arm.com> - 2016-06-27 13:30 +0200
Re: [PATCH 4/7] efi: Convert efi_call_virt to efi_call_virt_pointer Matt Fleming <matt@codeblueprint.co.uk> - 2016-07-04 15:20 +0200
[tip:efi/core] efi: Convert efi_call_virt() to efi_call_virt_pointer() tip-bot for Alex Thorlton <tipbot@zytor.com> - 2016-06-27 15:10 +0200
csiph-web