Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1431212
| Path | csiph.com!goblin1!goblin2!goblin.stu.neva.ru!gothmog.csi.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4/4] tty/serial: atmel: enforce tasklet init and termination sequences |
| Date | Sat, 25 Jun 2016 22:50:01 +0200 |
| Message-ID | <rO2GB-1Ey-1@gated-at.bofh.it> (permalink) |
| References | <rKYSS-5cu-3@gated-at.bofh.it> <rKYSS-5cu-7@gated-at.bofh.it> |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.6.1 (2016-04-27) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 20 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | linux-arm-kernel@lists.infradead.org, Alexandre Belloni <alexandre.belloni@free-electrons.com>, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Boris BREZILLON <boris.brezillon@free-electrons.com>, Ludovic Desroches <ludovic.desroches@atmel.com> |
| X-Original-Date | Sat, 25 Jun 2016 13:39:59 -0700 |
| X-Original-Message-ID | <20160625203959.GA22761@kroah.com> |
| X-Original-References | <cover.1466157015.git.nicolas.ferre@atmel.com> <5a52e1fbd8ec126bebfcd00f35bfe5af605ee914.1466157015.git.nicolas.ferre@atmel.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1431212 |
Show key headers only | View raw
On Fri, Jun 17, 2016 at 12:05:49PM +0200, Nicolas Ferre wrote: > As some race conditions are identified in the termination process of tasklets, > enforce the atmel_shutdown() sequence. This way we make sure that no new > tasklets or software timer are scheduled during shutdown process. > > An atomic flag is positioned to give this information throughout the code. > > We also remove tasklet_disable() calls that were leading to deadlocks while > stopping the driver. A simpler init/kill sequence is used. > > Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com> > --- > drivers/tty/serial/atmel_serial.c | 61 ++++++++++++++++++++++++--------------- > 1 file changed, 38 insertions(+), 23 deletions(-) You obviously didn't even test build this patch, as it breaks the build :( please be more careful... greg k-h
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [PATCH 4/4] tty/serial: atmel: enforce tasklet init and termination sequences Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-06-25 22:50 +0200 [PATCH v2] tty/serial: atmel: enforce tasklet init and termination sequences Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-06-26 09:50 +0200
csiph-web