Re: [PATCH 4/4] tty/serial: atmel: enforce tasklet init and termination sequences

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/4] tty/serial: atmel: enforce tasklet init and termination sequences
Date	2016-06-25 22:50 +0200
Message-ID	<rO2GB-1Ey-1@gated-at.bofh.it> (permalink)
References	<rKYSS-5cu-3@gated-at.bofh.it> <rKYSS-5cu-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jun 17, 2016 at 12:05:49PM +0200, Nicolas Ferre wrote:
> As some race conditions are identified in the termination process of tasklets,
> enforce the atmel_shutdown() sequence. This way we make sure that no new
> tasklets or software timer are scheduled during shutdown process.
> 
> An atomic flag is positioned to give this information throughout the code.
> 
> We also remove tasklet_disable() calls that were leading to deadlocks while
> stopping the driver. A simpler init/kill sequence is used.
> 
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
>  drivers/tty/serial/atmel_serial.c | 61 ++++++++++++++++++++++++---------------
>  1 file changed, 38 insertions(+), 23 deletions(-)

You obviously didn't even test build this patch, as it breaks the build :(

please be more careful...

greg k-h

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 4/4] tty/serial: atmel: enforce tasklet init and  termination sequences Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-06-25 22:50 +0200
  [PATCH v2] tty/serial: atmel: enforce tasklet init and termination sequences Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-06-26 09:50 +0200

csiph-web