Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1430259

Re: [PATCH] staging: wilc1000: arrays can't be NULL

Show all headers | View raw

On 24/06/16 00:54, Julian Calaby wrote:
> Hi Luis,
> 
> On Fri, Jun 24, 2016 at 9:50 AM, Luis de Bethencourt
> <luisbg@osg.samsung.com> wrote:
>> On 24/06/16 00:15, Julian Calaby wrote:
>>> Hi Joe,
>>>
>>> On Fri, Jun 24, 2016 at 5:24 AM, Joe Perches <joe@perches.com> wrote:
>>>> On Thu, 2016-06-23 at 18:57 +0100, Luis de Bethencourt wrote:
>>>>> hif_drv->usr_scan_req.net.net_info[i] contains found_net_info structs
>>>>> which have the following element:
>>>>> u8 bssid[6];
>>>> []
>>>>> I am aware this patch gives a few checkpatch.pl warnings about lines being
>>>>> over 80 characters. Fixing that would be a completely different issue, and
>>>>> a lengthy one since the file has loads of them.
>>>>>
>>>>> Hopefully somebody else picks that up. Maybe I should send a hit to the
>>>>> kernelnewbies mailing list :)
>>>>
>>>> Or not.
>>>>
>>>> really_long_identifiers™ makes using 80 columns silly.
>>>>
>>>> The hungarian could probably be converted though.
>>>
>>> The main developers of this driver are slowly working through the
>>> driver's style issues, which is part of the reason why it's in
>>> staging.
>>>
>>> Thanks,
>>>
>>
>> I understand Julian,
>>
>> All the maintainers listed in the MAINTAINERS file are in CC. I will wait for
>> them to OK the suggestion of sending a patch fixing the Hungarian Notation.
> 
> I was letting you know that this work is going to happen, not
> dissuading you from doing it.
> 
>> Didn't mean to step on your toes. I just wanted to help.
> 
> No toes were stepped on. As I said, this was not a "don't do that"
> message, this was an "it's going to happen eventually" message.
> 
>> Code in staging is cared for by a lot of people :)
> 
> Indeed it is.
> 
> Thanks,
> 

Gotcha.

I will send the Hungarian Notation change tomorrow. Since it is some small help.

I will let the memcpy/memcp to ether_addr_* change for the maintainers. I believe
it will happen soon.

Thanks for your input.

Luis

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: wilc1000: arrays can't be NULL Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-06-23 20:00 +0200
  Re: [PATCH] staging: wilc1000: arrays can't be NULL Joe Perches <joe@perches.com> - 2016-06-23 21:30 +0200
    Re: [PATCH] staging: wilc1000: arrays can't be NULL Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-06-23 23:40 +0200
    Re: [PATCH] staging: wilc1000: arrays can't be NULL Julian Calaby <julian.calaby@gmail.com> - 2016-06-24 01:20 +0200
      Re: [PATCH] staging: wilc1000: arrays can't be NULL Julian Calaby <julian.calaby@gmail.com> - 2016-06-24 02:00 +0200
        Re: [PATCH] staging: wilc1000: arrays can't be NULL Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-06-24 02:30 +0200
      Re: [PATCH] staging: wilc1000: arrays can't be NULL Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-06-24 02:00 +0200

csiph-web