Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1430240

Re: [PATCH] staging: wilc1000: arrays can't be NULL

Show all headers | View raw

Hi Joe,

On Fri, Jun 24, 2016 at 5:24 AM, Joe Perches <joe@perches.com> wrote:
> On Thu, 2016-06-23 at 18:57 +0100, Luis de Bethencourt wrote:
>> hif_drv->usr_scan_req.net.net_info[i] contains found_net_info structs
>> which have the following element:
>> u8 bssid[6];
> []
>> I am aware this patch gives a few checkpatch.pl warnings about lines being
>> over 80 characters. Fixing that would be a completely different issue, and
>> a lengthy one since the file has loads of them.
>>
>> Hopefully somebody else picks that up. Maybe I should send a hit to the
>> kernelnewbies mailing list :)
>
> Or not.
>
> really_long_identifiers™ makes using 80 columns silly.
>
> The hungarian could probably be converted though.

The main developers of this driver are slowly working through the
driver's style issues, which is part of the reason why it's in
staging.

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: wilc1000: arrays can't be NULL Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-06-23 20:00 +0200
  Re: [PATCH] staging: wilc1000: arrays can't be NULL Joe Perches <joe@perches.com> - 2016-06-23 21:30 +0200
    Re: [PATCH] staging: wilc1000: arrays can't be NULL Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-06-23 23:40 +0200
    Re: [PATCH] staging: wilc1000: arrays can't be NULL Julian Calaby <julian.calaby@gmail.com> - 2016-06-24 01:20 +0200
      Re: [PATCH] staging: wilc1000: arrays can't be NULL Julian Calaby <julian.calaby@gmail.com> - 2016-06-24 02:00 +0200
        Re: [PATCH] staging: wilc1000: arrays can't be NULL Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-06-24 02:30 +0200
      Re: [PATCH] staging: wilc1000: arrays can't be NULL Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-06-24 02:00 +0200

csiph-web