Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1430011

Re: [PATCH V4 1/3] x86/ioapic: Support hot-removal of IOAPICs present during boot

From Bjorn Helgaas <helgaas@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH V4 1/3] x86/ioapic: Support hot-removal of IOAPICs present during boot
Date 2016-06-23 19:40 +0200
Message-ID <rNgLE-4Qw-15@gated-at.bofh.it> (permalink)
References <rMS6B-57o-1@gated-at.bofh.it> <rN5nb-5t9-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 23, 2016 at 01:11:41PM +0800,  wrote:
> From: Rui Wang <rui.y.wang@intel.com>
> 
> On Wed, June 22, 2016 11:15 PM Bjorn Helgaas wrote:
> > [...]
> > > @@ -1779,8 +1780,12 @@ void __init
> > > pci_assign_unassigned_resources(void)
> > >  {
> > >  	struct pci_bus *root_bus;
> > >
> > > -	list_for_each_entry(root_bus, &pci_root_buses, node)
> > > +	list_for_each_entry(root_bus, &pci_root_buses, node) {
> > >  		pci_assign_unassigned_root_bus_resources(root_bus);
> > > +#ifdef CONFIG_X86
> > > +		acpi_ioapic_add(ACPI_HANDLE(root_bus->bridge));
> > > +#endif
> > 
> > Doesn't this do the right thing even if you omit the #ifdefs, since you
> > define a stub function below?
> > 
> 
> No. Without the '#ifdef CONFIG_X86' it breaks MIPS arch. The stub function is
> within 'ifdef CONFIG_ACPI'. On archs without ACPI it doesn't compile due to
> 'undefined reference to acpi_ioapic_add'.

But this *could* be made to work by defining a stub for the
non-CONFIG_ACPI case.  That's what we generally do to avoid ifdefs in
the code.

Bjorn

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH V3 1/3] x86/ioapic: Support hot-removal of IOAPICs present during boot Rui Wang <rui.y.wang@intel.com> - 2016-06-12 08:30 +0200
  Re: [PATCH V3 1/3] x86/ioapic: Support hot-removal of IOAPICs  present during boot Bjorn Helgaas <helgaas@kernel.org> - 2016-06-16 19:20 +0200
    RE: [PATCH V3 1/3] x86/ioapic: Support hot-removal of IOAPICs present during boot Rui Wang <rui.y.wang@intel.com> - 2016-06-22 09:30 +0200
      Re: [PATCH V3 1/3] x86/ioapic: Support hot-removal of IOAPICs  present during boot Bjorn Helgaas <helgaas@kernel.org> - 2016-06-22 17:20 +0200
        Re: [PATCH V3 1/3] x86/ioapic: Support hot-removal of IOAPICs present during boot Rui Wang <rui.y.wang@intel.com> - 2016-06-24 17:40 +0200
    [PATCH V4 1/3] x86/ioapic: Support hot-removal of IOAPICs present during boot Rui Wang <rui.y.wang@intel.com> - 2016-06-22 10:00 +0200
      Re: [PATCH V4 1/3] x86/ioapic: Support hot-removal of IOAPICs  present during boot Bjorn Helgaas <helgaas@kernel.org> - 2016-06-22 17:20 +0200
        Re: [PATCH V4 1/3] x86/ioapic: Support hot-removal of IOAPICs present during boot <> - 2016-06-23 07:30 +0200
          Re: [PATCH V4 1/3] x86/ioapic: Support hot-removal of IOAPICs  present during boot Bjorn Helgaas <helgaas@kernel.org> - 2016-06-23 19:40 +0200
            Re: [PATCH V4 1/3] x86/ioapic: Support hot-removal of IOAPICs present during boot Rui Wang <rui.y.wang@intel.com> - 2016-06-24 17:50 +0200
            [PATCH V5 1/3] x86/ioapic: Support hot-removal of IOAPICs present during boot Rui Wang <rui.y.wang@intel.com> - 2016-06-26 06:10 +0200

csiph-web