Re: [PATCH] wlcore: time sync : add support for 64 bit clock

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Johannes Berg <johannes@sipsolutions.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] wlcore: time sync : add support for 64 bit clock
Date	Thu, 23 Jun 2016 13:20:01 +0200
Message-ID	<rNaPT-IX-1@gated-at.bofh.it> (permalink)
References	<rNaPT-IX-3@gated-at.bofh.it> <rNaPT-IX-5@gated-at.bofh.it> <rNaPT-IX-3@gated-at.bofh.it>
X-Original-To	Yaniv Machani <yanivma@ti.com>, linux-kernel@vger.kernel.org
Content-Type	text/plain; charset="UTF-8"
X-Mailer	Evolution 3.20.2-2
MIME-Version	1.0
Content-Transfer-Encoding	8bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	29
Organization	linux.* mail to news gateway
X-Original-Cc	Kalle Valo <kvalo@codeaurora.org>, Guy Mishol <guym@ti.com>, Eliad Peller <eliad@wizery.com>, linux-wireless@vger.kernel.org, netdev@vger.kernel.org
X-Original-Date	Thu, 23 Jun 2016 13:18:00 +0200
X-Original-Message-ID	<1466680680.11061.2.camel@sipsolutions.net>
X-Original-References	<20160623111332.23326-1-yanivma@ti.com> (sfid-20160623_131215_419855_E4550AFE) <20160623111332.23326-1-yanivma@ti.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1429679

Show key headers only | View raw

On Thu, 2016-06-23 at 14:12 +0300, Yaniv Machani wrote:
> Changed the configuration to support 64bit instead of 32bit
> this in order to offload the driver from handling a wraparound.

[...]

Since you Cc'ed me, and presumably want me to review it, I'll say that
this looks like a terrible idea:

> @@ -74,10 +74,16 @@ struct wl18xx_event_mailbox {

This struct is evidently used for firmware/host communication.

>  	__le16 bss_loss_bitmap;
>  
>  	/* bitmap of stations (by HLID) which exceeded max tx
> retries */
> -	__le32 tx_retry_exceeded_bitmap;
> +	__le16 tx_retry_exceeded_bitmap;
> +
> +	/* time sync high msb*/
> +	u16 time_sync_tsf_high_msb;

So first of all, just using u16 instead of __le16 seems wrong.

Additionally, this looks like it changes the firmware API, so that
older firmware images will no longer work?

johannes

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] wlcore: time sync : add support for 64 bit clock Johannes Berg <johannes@sipsolutions.net> - 2016-06-23 13:20 +0200
  RE: [PATCH] wlcore: time sync : add support for 64 bit clock "Machani, Yaniv" <yanivma@ti.com> - 2016-06-23 13:40 +0200
    Re: [PATCH] wlcore: time sync : add support for 64 bit clock Johannes Berg <johannes@sipsolutions.net> - 2016-06-23 13:40 +0200

csiph-web