Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1429678

Re: [PATCH 04/27] mm, vmscan: Begin reclaiming pages on a per-node basis

From Mel Gorman <mgorman@techsingularity.net>
Newsgroups linux.kernel
Subject Re: [PATCH 04/27] mm, vmscan: Begin reclaiming pages on a per-node basis
Date 2016-06-23 13:10 +0200
Message-ID <rNaGd-zO-1@gated-at.bofh.it> (permalink)
References <rMuGZ-6Vn-3@gated-at.bofh.it> <rMuGZ-6Vn-7@gated-at.bofh.it> <rMR0S-4u2-21@gated-at.bofh.it> <rMST0-5Fj-55@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 22, 2016 at 06:00:12PM +0200, Vlastimil Babka wrote:
> >>-		enum zone_type classzone_idx;
> >>-
> >> 		if (!populated_zone(zone))
> >> 			continue;
> >>
> >>-		classzone_idx = requested_highidx;
> >>+		/*
> >>+		 * Note that reclaim_idx does not change as it is the highest
> >>+		 * zone reclaimed from which for empty zones is a no-op but
> >>+		 * classzone_idx is used by shrink_node to test if the slabs
> >>+		 * should be shrunk on a given node.
> >>+		 */
> >> 		while (!populated_zone(zone->zone_pgdat->node_zones +
> >>-							classzone_idx))
> >>+							classzone_idx)) {
> >> 			classzone_idx--;
> >>+			continue;
> 
> Oh and Michal's comment on Patch 20 made me realize that my objection to v6
> about possible underflow of sc->reclaim_idx and classzone_idx seems to still
> apply here for classzone_idx?

Potentially. The relevant code now looks like this

                classzone_idx = sc->reclaim_idx;
                while (!populated_zone(zone->zone_pgdat->node_zones +
                                                        classzone_idx))
                        classzone_idx--;

-- 
Mel Gorman
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 04/27] mm, vmscan: Begin reclaiming pages on a per-node basis Mel Gorman <mgorman@techsingularity.net> - 2016-06-21 16:20 +0200
  Re: [PATCH 04/27] mm, vmscan: Begin reclaiming pages on a per-node  basis Vlastimil Babka <vbabka@suse.cz> - 2016-06-22 16:10 +0200
    Re: [PATCH 04/27] mm, vmscan: Begin reclaiming pages on a per-node  basis Vlastimil Babka <vbabka@suse.cz> - 2016-06-22 18:10 +0200
      Re: [PATCH 04/27] mm, vmscan: Begin reclaiming pages on a per-node  basis Mel Gorman <mgorman@techsingularity.net> - 2016-06-23 13:10 +0200
        Re: [PATCH 04/27] mm, vmscan: Begin reclaiming pages on a per-node  basis Michal Hocko <mhocko@kernel.org> - 2016-06-23 13:20 +0200
    Re: [PATCH 04/27] mm, vmscan: Begin reclaiming pages on a per-node  basis Mel Gorman <mgorman@techsingularity.net> - 2016-06-23 13:00 +0200

csiph-web