Re: [PATCH] mfd: intel-lpss: fix compilation issue if PM_SLEEP is not set

From	Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mfd: intel-lpss: fix compilation issue if PM_SLEEP is not set
Date	2016-06-25 00:10 +0200
Message-ID	<rNHst-5xO-7@gated-at.bofh.it> (permalink)
References	<rNn0J-Mw-3@gated-at.bofh.it> <rNuEV-5Fl-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 24.06.2016 11:28, Andy Shevchenko wrote:
> On Fri, 2016-06-24 at 03:11 +0300, Vladimir Zapolskiy wrote:
>> If kernel build configuration has enabled CONFIG_PM and unset
>> CONFIG_PM_SLEEP, then intel-lpss-pci.c and intel-lpss-acpi.c can not
>> be compiled due to a missing INTEL_LPSS_SLEEP_PM_OPS macro
>> declaration:
>>
>>   drivers/mfd/intel-lpss-pci.c:63:8: error: undefined identifier
>> 'INTEL_LPSS_SLEEP_PM_OPS'
>>   drivers/mfd/intel-lpss-pci.c:63:58: error: ‘INTEL_LPSS_SLEEP_PM_OPS’
>> undeclared here (not in a function)
> 
> And may I ask what ancient kernel you are using?
> 
> commit 47b91923ea41288751e83a5b080576085a831333
> Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Date:   Mon Sep 14 11:32:47 2015 +0300
> 
>     mfd: intel-lpss: Fix build error when !CONFIG_PM_SLEEP

The original driver was backported to 4.1

Thanks for the reference to a fixup, I'll backport it as well.

Lee, please ignore this change.

--
With best wishes,
Vladimir

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mfd: intel-lpss: fix compilation issue if PM_SLEEP is not set Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-06-24 02:20 +0200
  Re: [PATCH] mfd: intel-lpss: fix compilation issue if PM_SLEEP is not  set Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-06-24 02:20 +0200
  Re: [PATCH] mfd: intel-lpss: fix compilation issue if PM_SLEEP is  not set Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-06-24 10:30 +0200
    Re: [PATCH] mfd: intel-lpss: fix compilation issue if PM_SLEEP is not  set Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-06-25 00:10 +0200

csiph-web