Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1430984

Re: Kernel 4.7rc3 - Performance drop 30-40% for SPECjbb2005 and SPECjvm2008 benchmarks against 4.6 kernel

From Jirka Hladky <jhladky@redhat.com>
Newsgroups linux.kernel
Subject Re: Kernel 4.7rc3 - Performance drop 30-40% for SPECjbb2005 and SPECjvm2008 benchmarks against 4.6 kernel
Date 2016-06-25 00:20 +0200
Message-ID <rNHC9-5AP-1@gated-at.bofh.it> (permalink)
References (5 earlier) <rNu2d-5cW-7@gated-at.bofh.it> <rNy5P-7Tc-5@gated-at.bofh.it> <rNyIx-86a-13@gated-at.bofh.it> <rNzEC-h8-13@gated-at.bofh.it> <rNBGq-1Ax-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi Peter,

I have compiled your version of linux kernel and run the SPECjvm2008
tests. Results are fine, performance is at the level of 4.6 kernel.

$ git rev-parse HEAD
02548776ded1185e6e16ad0a475481e982741ee9

Jirka




On Fri, Jun 24, 2016 at 5:54 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Fri, Jun 24, 2016 at 03:42:26PM +0200, Peter Zijlstra wrote:
>> On Fri, Jun 24, 2016 at 02:44:07PM +0200, Vincent Guittot wrote:
>> > > --- a/kernel/sched/fair.c
>> > > +++ b/kernel/sched/fair.c
>> > > @@ -2484,7 +2484,7 @@ static inline long calc_tg_weight(struct task_group *tg, struct cfs_rq *cfs_rq)
>> > >          */
>> > >         tg_weight = atomic_long_read(&tg->load_avg);
>> > >         tg_weight -= cfs_rq->tg_load_avg_contrib;
>> > > -       tg_weight += cfs_rq->load.weight;
>> > > +       tg_weight += cfs_rq->avg.load_avg;
>> >
>> > IIUC, you are reverting
>> > commit  fde7d22e01aa (sched/fair: Fix overly small weight for
>> > interactive group entities)
>>
>> Hurm.. looking at that commit again, that seems to wreck
>> effective_load(), since that doesn't compensate.
>>
>> Maybe I'll remove calc_tg_weight and open code its slightly different
>> usages in the two sites.
>
> OK, sorry for not actually posting, but I need to run. Please find the
> two patches in:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/urgent

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: Kernel 4.7rc3 - Performance drop 30-40% for SPECjbb2005 and  SPECjvm2008 benchmarks against 4.6 kernel Peter Zijlstra <peterz@infradead.org> - 2016-06-23 20:40 +0200
  Re: Kernel 4.7rc3 - Performance drop 30-40% for SPECjbb2005 and  SPECjvm2008 benchmarks against 4.6 kernel Peter Zijlstra <peterz@infradead.org> - 2016-06-23 20:50 +0200
    Re: Kernel 4.7rc3 - Performance drop 30-40% for SPECjbb2005 and  SPECjvm2008 benchmarks against 4.6 kernel Jirka Hladky <jhladky@redhat.com> - 2016-06-24 09:50 +0200
      Re: Kernel 4.7rc3 - Performance drop 30-40% for SPECjbb2005 and  SPECjvm2008 benchmarks against 4.6 kernel Peter Zijlstra <peterz@infradead.org> - 2016-06-24 10:10 +0200
        Re: Kernel 4.7rc3 - Performance drop 30-40% for SPECjbb2005 and  SPECjvm2008 benchmarks against 4.6 kernel Jirka Hladky <jhladky@redhat.com> - 2016-06-24 10:30 +0200
      Re: Kernel 4.7rc3 - Performance drop 30-40% for SPECjbb2005 and  SPECjvm2008 benchmarks against 4.6 kernel Jirka Hladky <jhladky@redhat.com> - 2016-06-24 14:10 +0200
        Re: Kernel 4.7rc3 - Performance drop 30-40% for SPECjbb2005 and  SPECjvm2008 benchmarks against 4.6 kernel Jirka Hladky <jhladky@redhat.com> - 2016-06-24 14:40 +0200
        Re: Kernel 4.7rc3 - Performance drop 30-40% for SPECjbb2005 and  SPECjvm2008 benchmarks against 4.6 kernel Peter Zijlstra <peterz@infradead.org> - 2016-06-24 14:40 +0200
      Re: Kernel 4.7rc3 - Performance drop 30-40% for SPECjbb2005 and  SPECjvm2008 benchmarks against 4.6 kernel Peter Zijlstra <peterz@infradead.org> - 2016-06-24 14:10 +0200
        Re: Kernel 4.7rc3 - Performance drop 30-40% for SPECjbb2005 and  SPECjvm2008 benchmarks against 4.6 kernel Vincent Guittot <vincent.guittot@linaro.org> - 2016-06-24 14:50 +0200
          Re: Kernel 4.7rc3 - Performance drop 30-40% for SPECjbb2005 and  SPECjvm2008 benchmarks against 4.6 kernel Peter Zijlstra <peterz@infradead.org> - 2016-06-24 15:10 +0200
            Re: Kernel 4.7rc3 - Performance drop 30-40% for SPECjbb2005 and  SPECjvm2008 benchmarks against 4.6 kernel Vincent Guittot <vincent.guittot@linaro.org> - 2016-06-24 15:30 +0200
              Re: Kernel 4.7rc3 - Performance drop 30-40% for SPECjbb2005 and  SPECjvm2008 benchmarks against 4.6 kernel Peter Zijlstra <peterz@infradead.org> - 2016-06-24 15:40 +0200
              Re: Kernel 4.7rc3 - Performance drop 30-40% for SPECjbb2005 and  SPECjvm2008 benchmarks against 4.6 kernel Peter Zijlstra <peterz@infradead.org> - 2016-06-24 15:50 +0200
          Re: Kernel 4.7rc3 - Performance drop 30-40% for SPECjbb2005 and  SPECjvm2008 benchmarks against 4.6 kernel Jirka Hladky <jhladky@redhat.com> - 2016-06-24 15:10 +0200
          Re: Kernel 4.7rc3 - Performance drop 30-40% for SPECjbb2005 and  SPECjvm2008 benchmarks against 4.6 kernel Peter Zijlstra <peterz@infradead.org> - 2016-06-24 15:50 +0200
            Re: Kernel 4.7rc3 - Performance drop 30-40% for SPECjbb2005 and  SPECjvm2008 benchmarks against 4.6 kernel Peter Zijlstra <peterz@infradead.org> - 2016-06-24 18:00 +0200
              Re: Kernel 4.7rc3 - Performance drop 30-40% for SPECjbb2005 and  SPECjvm2008 benchmarks against 4.6 kernel Jirka Hladky <jhladky@redhat.com> - 2016-06-25 00:20 +0200

csiph-web