Re: [PATCH] Maxim/driver: Add driver for maxim ds26522

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Maxim/driver: Add driver for maxim ds26522
Date	2016-06-24 21:50 +0200
Message-ID	<rNFgZ-40R-1@gated-at.bofh.it> (permalink)
References	<rN3EJ-4ef-7@gated-at.bofh.it> <rNegN-32O-9@gated-at.bofh.it> <rNs0p-42y-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Qiang Zhao <qiang.zhao@nxp.com>
Date: Fri, 24 Jun 2016 02:00:33 +0000

> On Thu, 2016-06-23 at 10:59PM, David Miller wrote:
>> -----Original Message-----
>> From: David Miller [mailto:davem@davemloft.net]
>> Sent: Thursday, June 23, 2016 10:59 PM
>> To: Qiang Zhao <qiang.zhao@nxp.com>
>> Cc: oss@buserror.net; linux-kernel@vger.kernel.org; netdev@vger.kernel.org;
>> Xiaobo Xie <xiaobo.xie@nxp.com>
>> Subject: Re: [PATCH] Maxim/driver: Add driver for maxim ds26522
>> 
>> From: Zhao Qiang <qiang.zhao@nxp.com>
>> Date: Thu, 23 Jun 2016 09:09:45 +0800
>> 
>> > +MODULE_DESCRIPTION(DRV_DESC);
>> 
>> There is no definition of DRV_DESC, so this makes it look like you didn't even
>> compile this driver.
> 
> I really, really compiled this driver.
> Thank you for your review and comments. I will modify it the next version.
> 
> [zhaoqiang@titan:~/upstream/linux]$ll drivers/net/wan/slic_ds26522.o
> -rw-r--r-- 1 zhaoqiang klocwork 153288 Jun 22 15:48 drivers/net/wan/slic_ds26522.o
> [zhaoqiang@titan:~/upstream/linux]$date

Obviously with the driver not configured as a module, and thus explicitly
not testing the failing statement at all.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

RE: [PATCH] Maxim/driver: Add driver for maxim ds26522 Qiang Zhao <qiang.zhao@nxp.com> - 2016-06-24 07:40 +0200
  Re: [PATCH] Maxim/driver: Add driver for maxim ds26522 David Miller <davem@davemloft.net> - 2016-06-24 21:50 +0200

csiph-web