Re: [PATCH 1/5] tpm: unify tpm_gen_interrupt()

From	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/5] tpm: unify tpm_gen_interrupt()
Date	2016-06-24 21:40 +0200
Message-ID	<rNF7j-3VP-9@gated-at.bofh.it> (permalink)
References	<rL9lf-3mT-3@gated-at.bofh.it> <rL9lf-3mT-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jun 17, 2016 at 11:10:43PM +0200, Jarkko Sakkinen wrote:
>  extern int tpm_get_timeouts(struct tpm_chip *);
> -extern void tpm_gen_interrupt(struct tpm_chip *);
> +void tpm_gen_interrupt(struct tpm_chip *);

Dropping the argument name is not the kernel standard, if these lines
are going to be churned they may as well be churned to the standard.

FWIW, all the extern's should be dropped too.

Jason

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/5] tpm: unify tpm_gen_interrupt() Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-06-24 21:40 +0200
  Re: [PATCH 1/5] tpm: unify tpm_gen_interrupt() Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-06-24 22:30 +0200

csiph-web