Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1429361

Re: [PATCH] acpi: pci_slot: Use more common logging style

Path csiph.com!news.freedyn.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From "Rafael J. Wysocki" <rjw@rjwysocki.net>
Newsgroups linux.kernel
Subject Re: [PATCH] acpi: pci_slot: Use more common logging style
Date Thu, 23 Jun 2016 02:30:02 +0200
Message-ID <rN0GS-2fs-9@gated-at.bofh.it> (permalink)
References <rDsuJ-5E6-3@gated-at.bofh.it>
X-Original-To Joe Perches <joe@perches.com>
User-Agent KMail/4.11.5 (Linux/4.5.0-rc1+; KDE/4.11.5; x86_64; ; )
MIME-Version 1.0
Content-Transfer-Encoding 7Bit
Content-Type text/plain; charset="utf-8"
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 19
Organization linux.* mail to news gateway
X-Original-Cc Len Brown <lenb@kernel.org>, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date Thu, 23 Jun 2016 02:32:57 +0200
X-Original-Message-ID <7494572.5I6HybzNKa@vostro.rjw.lan>
X-Original-References <fdc546e7c5bb8b3d7e37a1721e5158fc2217d6ee.1464364797.git.joe@perches.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1429361

Show key headers only | View raw


On Friday, May 27, 2016 09:00:28 AM Joe Perches wrote:
> Use generic pr_<level> functions with pr_fmt for info and err.
> 
> This also reduces object size a trivial bit:
> 
> $ size drivers/acpi/pci_slot.o*
>    text	   data	    bss	    dec	    hex	filename
>     935	    752	      5	   1692	    69c	drivers/acpi/pci_slot.o.new
>    1027	    752	      5	   1784	    6f8	drivers/acpi/pci_slot.o.old
> 
> Miscellanea:
> 
> o Remove unnecessary OOM message as k.alloc functions get a generic
>   stack dump on OOM
> o Remove unnecessary embedded prefix from a dbg() message
> 
> Signed-off-by: Joe Perches <joe@perches.com>

Applied, thanks!

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] acpi: pci_slot: Use more common logging style "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-23 02:30 +0200

csiph-web