Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1429362

Re: [PATCH] acpi: thermal: Remove create_workqueue

From "Rafael J. Wysocki" <rjw@rjwysocki.net>
Newsgroups linux.kernel
Subject Re: [PATCH] acpi: thermal: Remove create_workqueue
Date 2016-06-23 02:40 +0200
Message-ID <rN0Qx-2iS-1@gated-at.bofh.it> (permalink)
References <rHfIC-5zJ-9@gated-at.bofh.it> <rHq1k-3KB-33@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tuesday, June 07, 2016 09:13:51 AM Tejun Heo wrote:
> On Tue, Jun 07, 2016 at 08:45:40AM +0530, Bhaktipriya Shridhar wrote:
> > alloc_workqueue replaces deprecated create_workqueue().
> > 
> > A dedicated workqueue has been used since the workqueue
> > acpi_thermal_pm_queue with workitem &tz->thermal_check_work
> > (maps to acpi_thermal_check_fn), is involved in thermal zone polling.
> > Wallclock time is actually important and getting delayed in handling
> > critical temperature event can actually lead to unnecessary hardware
> > damage. So while this is not used during memory reclaim, we still want
> > forward progress guarantee and be generally snappy in servicing it.
> > Hence, WQ_MEM_RECLAIM and WQ_HIGHPRI have been used here.
> > 
> > Since there are only a fixed number of work items, explicit concurrency
> > limit is unnecessary here.
> > 
> > Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> 
> Acked-by: Tejun Heo <tj@kernel.org>

Patch applied, thanks!

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] acpi: thermal: Remove create_workqueue "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-23 02:40 +0200

csiph-web