Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1427709

Re: [PATCH v12 2/4] gadget: Support for the usb charger framework

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

Baolin Wang <baolin.wang@linaro.org> writes:
>> Baolin Wang <baolin.wang@linaro.org> writes:
>>>> Baolin Wang <baolin.wang@linaro.org> writes:
>>>>>> Can't you just tie a charger to a UDC and avoid the charger class
>>>>>> completely?
>>>>>
>>>>> Yeah, I also hope so. But we really want something to manage the
>>>>> charger devices, do you have any good suggestion to avoid the 'class'
>>>>> but also can manage the charger devices?
>>>>
>>>> manage in what way? It seems to me that they don't need to be real
>>>> devices, just a handle as part of struct usb_gadget, no?
>>>
>>> Although charger device is not one real hardware device, we also use
>>> one 'struct device' to describe it in charger.c file. So we should
>>> manage the 'struct device' with one proper way.
>>
>> that's fine, but why do you think they need a struct device to start with?
>
> We can get/put usb charger and mange usb charger attributes with the
> device model if we use a struct device.

We already have that as part of struct usb_udc. Why don't you just
create a subdirectory called charger which will hold all your
charger-related attributes. That directory will only be created if a
valid ->charger pointer exists.

USB Charging is always tied to a peripheral side controller, anyway.

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v12 0/4] Introduce usb charger framework to deal with the usb gadget power negotation Baolin Wang <baolin.wang@linaro.org> - 2016-06-21 10:50 +0200
  [PATCH v12 2/4] gadget: Support for the usb charger framework Baolin Wang <baolin.wang@linaro.org> - 2016-06-21 10:50 +0200
    Re: [PATCH v12 2/4] gadget: Support for the usb charger framework Felipe Balbi <balbi@kernel.org> - 2016-06-21 12:40 +0200
      Re: [PATCH v12 2/4] gadget: Support for the usb charger framework Baolin Wang <baolin.wang@linaro.org> - 2016-06-21 13:30 +0200
        Re: [PATCH v12 2/4] gadget: Support for the usb charger framework Baolin Wang <baolin.wang@linaro.org> - 2016-06-21 14:10 +0200
          Re: [PATCH v12 2/4] gadget: Support for the usb charger framework Baolin Wang <baolin.wang@linaro.org> - 2016-06-21 14:40 +0200
            Re: [PATCH v12 2/4] gadget: Support for the usb charger framework Felipe Balbi <balbi@kernel.org> - 2016-06-21 14:50 +0200
              Re: [PATCH v12 2/4] gadget: Support for the usb charger framework Baolin Wang <baolin.wang@linaro.org> - 2016-06-21 14:50 +0200
                Re: [PATCH v12 2/4] gadget: Support for the usb charger framework Felipe Balbi <balbi@kernel.org> - 2016-06-21 15:00 +0200
                Re: [PATCH v12 2/4] gadget: Support for the usb charger framework Felipe Balbi <balbi@kernel.org> - 2016-06-21 15:20 +0200
                Re: [PATCH v12 2/4] gadget: Support for the usb charger framework Baolin Wang <baolin.wang@linaro.org> - 2016-06-22 03:50 +0200
          Re: [PATCH v12 2/4] gadget: Support for the usb charger framework Felipe Balbi <balbi@kernel.org> - 2016-06-21 14:40 +0200
        Re: [PATCH v12 2/4] gadget: Support for the usb charger framework Felipe Balbi <balbi@kernel.org> - 2016-06-21 16:50 +0200
      Re: [PATCH v12 2/4] gadget: Support for the usb charger framework Baolin Wang <baolin.wang@linaro.org> - 2016-06-23 11:00 +0200
  [PATCH v12 3/4] gadget: Integrate with the usb gadget supporting for usb charger Baolin Wang <baolin.wang@linaro.org> - 2016-06-21 10:50 +0200
  [PATCH v12 1/4] gadget: Introduce the usb charger framework Baolin Wang <baolin.wang@linaro.org> - 2016-06-21 10:50 +0200
    Re: [PATCH v12 1/4] gadget: Introduce the usb charger framework Felipe Balbi <balbi@kernel.org> - 2016-06-21 12:40 +0200
      Re: [PATCH v12 1/4] gadget: Introduce the usb charger framework Baolin Wang <baolin.wang@linaro.org> - 2016-06-21 13:40 +0200
        Re: [PATCH v12 1/4] gadget: Introduce the usb charger framework Felipe Balbi <balbi@kernel.org> - 2016-06-21 17:00 +0200
          Re: [PATCH v12 1/4] gadget: Introduce the usb charger framework Baolin Wang <baolin.wang@linaro.org> - 2016-06-22 04:00 +0200

csiph-web