Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1427624

Re: [PATCH v12 2/4] gadget: Support for the usb charger framework

Show all headers | View raw

On 21 June 2016 at 18:27, Felipe Balbi <balbi@kernel.org> wrote:
>
> Hi,
>
> Baolin Wang <baolin.wang@linaro.org> writes:
>> For supporting the usb charger, it adds the usb_charger_init() and
>> usb_charger_exit() functions for usb charger initialization and exit.
>>
>> It will report to the usb charger when the gadget state is changed,
>> then the usb charger can do the power things.
>>
>> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
>> Reviewed-by: Li Jun <jun.li@nxp.com>
>> Tested-by: Li Jun <jun.li@nxp.com>
>
> Before anything, I must say that I really liked this patch. It's

Thanks.

> minimaly invasive to udc core and does all the necessary changes. If it
> wasn't for the extra charger class, this would've been perfect.
>
> Can't you just tie a charger to a UDC and avoid the charger class
> completely?

Yeah, I also hope so. But we really want something to manage the
charger devices, do you have any good suggestion to avoid the 'class'
but also can manage the charger devices?

>
>>  static inline int usb_gadget_vbus_draw(struct usb_gadget *gadget, unsigned mA)
>>  {
>> +     if (gadget->charger)
>
> I guess you could do this check inside
> usb_gadget_set_cur_limit_by_type() itself.

OK.

>
> --
> balbi



-- 
Baolin.wang
Best Regards

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v12 0/4] Introduce usb charger framework to deal with the usb gadget power negotation Baolin Wang <baolin.wang@linaro.org> - 2016-06-21 10:50 +0200
  [PATCH v12 2/4] gadget: Support for the usb charger framework Baolin Wang <baolin.wang@linaro.org> - 2016-06-21 10:50 +0200
    Re: [PATCH v12 2/4] gadget: Support for the usb charger framework Felipe Balbi <balbi@kernel.org> - 2016-06-21 12:40 +0200
      Re: [PATCH v12 2/4] gadget: Support for the usb charger framework Baolin Wang <baolin.wang@linaro.org> - 2016-06-21 13:30 +0200
        Re: [PATCH v12 2/4] gadget: Support for the usb charger framework Baolin Wang <baolin.wang@linaro.org> - 2016-06-21 14:10 +0200
          Re: [PATCH v12 2/4] gadget: Support for the usb charger framework Baolin Wang <baolin.wang@linaro.org> - 2016-06-21 14:40 +0200
            Re: [PATCH v12 2/4] gadget: Support for the usb charger framework Felipe Balbi <balbi@kernel.org> - 2016-06-21 14:50 +0200
              Re: [PATCH v12 2/4] gadget: Support for the usb charger framework Baolin Wang <baolin.wang@linaro.org> - 2016-06-21 14:50 +0200
                Re: [PATCH v12 2/4] gadget: Support for the usb charger framework Felipe Balbi <balbi@kernel.org> - 2016-06-21 15:00 +0200
                Re: [PATCH v12 2/4] gadget: Support for the usb charger framework Felipe Balbi <balbi@kernel.org> - 2016-06-21 15:20 +0200
                Re: [PATCH v12 2/4] gadget: Support for the usb charger framework Baolin Wang <baolin.wang@linaro.org> - 2016-06-22 03:50 +0200
          Re: [PATCH v12 2/4] gadget: Support for the usb charger framework Felipe Balbi <balbi@kernel.org> - 2016-06-21 14:40 +0200
        Re: [PATCH v12 2/4] gadget: Support for the usb charger framework Felipe Balbi <balbi@kernel.org> - 2016-06-21 16:50 +0200
      Re: [PATCH v12 2/4] gadget: Support for the usb charger framework Baolin Wang <baolin.wang@linaro.org> - 2016-06-23 11:00 +0200
  [PATCH v12 3/4] gadget: Integrate with the usb gadget supporting for usb charger Baolin Wang <baolin.wang@linaro.org> - 2016-06-21 10:50 +0200
  [PATCH v12 1/4] gadget: Introduce the usb charger framework Baolin Wang <baolin.wang@linaro.org> - 2016-06-21 10:50 +0200
    Re: [PATCH v12 1/4] gadget: Introduce the usb charger framework Felipe Balbi <balbi@kernel.org> - 2016-06-21 12:40 +0200
      Re: [PATCH v12 1/4] gadget: Introduce the usb charger framework Baolin Wang <baolin.wang@linaro.org> - 2016-06-21 13:40 +0200
        Re: [PATCH v12 1/4] gadget: Introduce the usb charger framework Felipe Balbi <balbi@kernel.org> - 2016-06-21 17:00 +0200
          Re: [PATCH v12 1/4] gadget: Introduce the usb charger framework Baolin Wang <baolin.wang@linaro.org> - 2016-06-22 04:00 +0200

csiph-web