Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1427491
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] scsi: wd7000: print sector number as 64-bit |
| Date | 2016-06-21 11:20 +0200 |
| Message-ID | <rMq0F-3PM-7@gated-at.bofh.it> (permalink) |
| References | <rMpQZ-3Mw-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, 2016-06-21 at 11:02 +0200, Arnd Bergmann wrote: > Enabling format checking in dprintk() shows that wd7000_biosparam > uses an incorrect format string for sector_t: trivia: > diff --git a/drivers/scsi/wd7000.c b/drivers/scsi/wd7000.c [] > @@ -192,7 +192,7 @@ > #ifdef WD7000_DEBUG > #define dprintk printk > #else > -#define dprintk(format,args...) > +#define dprintk no_printk > #endif It'd be nicer if both defines were the same form #ifdef WD7000_DEBUG #define dprintk printk #else #define dprintk no_printk #endif
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2] scsi: wd7000: print sector number as 64-bit Arnd Bergmann <arnd@arndb.de> - 2016-06-21 11:10 +0200 Re: [PATCH v2] scsi: wd7000: print sector number as 64-bit Joe Perches <joe@perches.com> - 2016-06-21 11:20 +0200 Re: [PATCH v2] scsi: wd7000: print sector number as 64-bit "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-06-22 04:30 +0200
csiph-web