Re: [PATCH 04/27] [AARCH64] Add PTR_REG, PTR_LOG_SIZE, and PTR_SIZE. Use it in LDST_PCREL and LDST_GLOBAL.

From	Andreas Schwab <schwab@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 04/27] [AARCH64] Add PTR_REG, PTR_LOG_SIZE, and PTR_SIZE. Use it in LDST_PCREL and LDST_GLOBAL.
Date	2016-06-21 11:20 +0200
Message-ID	<rMq0F-3PM-1@gated-at.bofh.it> (permalink)
References	<rMoBA-2OV-31@gated-at.bofh.it> <rMpxD-3qk-13@gated-at.bofh.it> <rMpxD-3qk-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Andreas Schwab <schwab@suse.de> writes:

>> +/* Load or store to/from a got-relative EXPR into/from R, using T.
>> +   Note R and T are register numbers and not register names.  */
>> +#define LDST_GLOBAL(OP, R, T,  EXPR)			\
>> +	adrp	x##T, :got:EXPR;			\
>> +	ldr	PTR_REG (T), [x##T, #:got_lo12:EXPR];	\
>> +	OP	x##R, [x##T];
>
> I think this needs to be PTR_REG(x).

I mean PTR_REG(R), of course.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 04/27] [AARCH64] Add PTR_REG, PTR_LOG_SIZE, and PTR_SIZE.  Use it in LDST_PCREL and LDST_GLOBAL. Andreas Schwab <schwab@suse.de> - 2016-06-21 10:50 +0200
  Re: [PATCH 04/27] [AARCH64] Add PTR_REG, PTR_LOG_SIZE, and PTR_SIZE.  Use it in LDST_PCREL and LDST_GLOBAL. Andreas Schwab <schwab@suse.de> - 2016-06-21 11:20 +0200

csiph-web