Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1427174

Re: [PATCH 2/2] scsi: wd7000: print sector number as 64-bit

From "Martin K. Petersen" <martin.petersen@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] scsi: wd7000: print sector number as 64-bit
Date 2016-06-21 03:20 +0200
Message-ID <rMiw9-7nZ-1@gated-at.bofh.it> (permalink)
References <rKpV7-7iY-15@gated-at.bofh.it> <rKq4N-7mg-3@gated-at.bofh.it>
Organization Oracle Corporation

Show all headers | View raw


>>>>> "Arnd" == Arnd Bergmann <arnd@arndb.de> writes:

As sector_t can be 32-bit wide, this adds a cast to 'u64' and prints
that with the correct format. The change to use no_printk()

[...]

+	dprintk("wd7000_biosparam: dev=%s, size=%lld, ",
+		bdevname(bdev, b), (s64)capacity);

s64?

Why not unsigned long long like we usually do with sector_t?

-- 
Martin K. Petersen	Oracle Linux Engineering

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] scsi: lpfc: avoid harmless comparison warning Arnd Bergmann <arnd@arndb.de> - 2016-06-15 22:50 +0200
  [PATCH 2/2] scsi: wd7000: print sector number as 64-bit Arnd Bergmann <arnd@arndb.de> - 2016-06-15 23:00 +0200
    Re: [PATCH 2/2] scsi: wd7000: print sector number as 64-bit "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-06-21 03:20 +0200
      Re: [PATCH 2/2] scsi: wd7000: print sector number as 64-bit Arnd Bergmann <arnd@arndb.de> - 2016-06-21 13:50 +0200
  Re: [PATCH 1/2] scsi: lpfc: avoid harmless comparison warning Johannes Thumshirn <jthumshirn@suse.de> - 2016-06-16 09:40 +0200

csiph-web