Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1428557
| From | Crestez Dan Leonard <leonard.crestez@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC] regmap: Add regmap_pipe_read API |
| Date | 2016-06-22 10:40 +0200 |
| Message-ID | <rMLRw-137-17@gated-at.bofh.it> (permalink) |
| References | <rKHoZ-1Bu-11@gated-at.bofh.it> <rMzdE-1pq-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 06/21/2016 09:42 PM, Mark Brown wrote: > On Thu, Jun 16, 2016 at 06:24:36PM +0300, Crestez Dan Leonard wrote: > >> + val = ((u8*)val) + read_len; > > This cast looks broken, you should be able to do pointer arithmetic on > void pointers as though they were char *. > Pointer arithmetic on void* is not standard C, it's a GCC extension. I know that GCC extensions are allowed for the kernel but is it really encouraged to rely on them this way? Anyway, are my concerns about the regmap_bus implementation for SPMI valid? In theory this could be submitted in it's present form and let regmap+spmi users If this API is otherwise fine I can just resend this marked as [PATCH] with the cast removed and some rearranged comments. -- Regards, Leonard
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC] regmap: Add regmap_pipe_read API Crestez Dan Leonard <leonard.crestez@intel.com> - 2016-06-16 17:30 +0200
Re: [RFC] regmap: Add regmap_pipe_read API Geert Uytterhoeven <geert@linux-m68k.org> - 2016-06-16 17:50 +0200
Re: [RFC] regmap: Add regmap_pipe_read API Crestez Dan Leonard <leonard.crestez@intel.com> - 2016-06-17 09:10 +0200
Re: [RFC] regmap: Add regmap_pipe_read API Lars-Peter Clausen <lars@metafoo.de> - 2016-06-17 10:10 +0200
Re: [RFC] regmap: Add regmap_pipe_read API Jonathan Cameron <jic23@kernel.org> - 2016-06-19 21:50 +0200
Re: [RFC] regmap: Add regmap_pipe_read API Mark Brown <broonie@kernel.org> - 2016-06-21 21:10 +0200
Re: [RFC] regmap: Add regmap_pipe_read API Crestez Dan Leonard <leonard.crestez@intel.com> - 2016-06-22 10:40 +0200
Re: [RFC] regmap: Add regmap_pipe_read API Mark Brown <broonie@kernel.org> - 2016-06-22 13:10 +0200
csiph-web