Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1424733

Re: [RFC] regmap: Add regmap_pipe_read API

Show all headers | View raw

On 06/16/2016 06:43 PM, Geert Uytterhoeven wrote:
> Hi Leonard,
> 
> On Thu, Jun 16, 2016 at 5:24 PM, Crestez Dan Leonard
> <leonard.crestez@intel.com> wrote:
>> The regmap API usually assumes that bulk read operations will read a
>> range of registers but some I2C/SPI devices have certain registers for
>> which a such a read operation will return data from an internal FIFO
>> instead. Add an explicit API to support bulk read with pipe rather than
>> range semantics.
> 
> Please settle on either "fifo" or "pipe", instead of mixing both.
> Personally, I prefer the former.

Well, it doesn't have to be a fifo. The device can return data from some
other kind of buffer (maybe a stack). I can adjust the documentation to
clarify.

I considered naming it something like regmap_multi_read_one_reg or
something but regmap_pipe_read sounds reasonable and short.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC] regmap: Add regmap_pipe_read API Crestez Dan Leonard <leonard.crestez@intel.com> - 2016-06-16 17:30 +0200
  Re: [RFC] regmap: Add regmap_pipe_read API Geert Uytterhoeven <geert@linux-m68k.org> - 2016-06-16 17:50 +0200
    Re: [RFC] regmap: Add regmap_pipe_read API Crestez Dan Leonard <leonard.crestez@intel.com> - 2016-06-17 09:10 +0200
      Re: [RFC] regmap: Add regmap_pipe_read API Lars-Peter Clausen <lars@metafoo.de> - 2016-06-17 10:10 +0200
        Re: [RFC] regmap: Add regmap_pipe_read API Jonathan Cameron <jic23@kernel.org> - 2016-06-19 21:50 +0200
  Re: [RFC] regmap: Add regmap_pipe_read API Mark Brown <broonie@kernel.org> - 2016-06-21 21:10 +0200
    Re: [RFC] regmap: Add regmap_pipe_read API Crestez Dan Leonard <leonard.crestez@intel.com> - 2016-06-22 10:40 +0200
      Re: [RFC] regmap: Add regmap_pipe_read API Mark Brown <broonie@kernel.org> - 2016-06-22 13:10 +0200

csiph-web