Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1428552
| From | tip-bot for Wang Nan <tipbot@zytor.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [tip:perf/core] perf record: Add --dry-run option to check cmdline options |
| Date | 2016-06-22 10:40 +0200 |
| Message-ID | <rMLRv-137-5@gated-at.bofh.it> (permalink) |
| References | <rKAxc-5MU-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Commit-ID: 0aab21363ffa66d6e7340bc50cc5bfae865fd1a6
Gitweb: http://git.kernel.org/tip/0aab21363ffa66d6e7340bc50cc5bfae865fd1a6
Author: Wang Nan <wangnan0@huawei.com>
AuthorDate: Thu, 16 Jun 2016 08:02:41 +0000
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 21 Jun 2016 13:18:35 -0300
perf record: Add --dry-run option to check cmdline options
With '--dry-run', 'perf record' doesn't do reall recording. Combine with
llvm.dump-obj option, --dry-run can be used to help compile BPF objects
for embedded platform.
Signed-off-by: Wang Nan <wangnan0@huawei.com>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/1466064161-48553-3-git-send-email-wangnan0@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/Documentation/perf-record.txt | 7 +++++++
tools/perf/builtin-record.c | 7 +++++++
2 files changed, 14 insertions(+)
diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt
index 8dbee83..5b46b1d 100644
--- a/tools/perf/Documentation/perf-record.txt
+++ b/tools/perf/Documentation/perf-record.txt
@@ -360,6 +360,13 @@ particular perf.data snapshot should be kept or not.
Implies --timestamp-filename, --no-buildid and --no-buildid-cache.
+--dry-run::
+Parse options then exit. --dry-run can be used to detect errors in cmdline
+options.
+
+'perf record --dry-run -e' can act as a BPF script compiler if llvm.dump-obj
+in config file is set to true.
+
SEE ALSO
--------
linkperf:perf-stat[1], linkperf:perf-list[1]
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index d4cf1b0..b1304eb 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -1274,6 +1274,8 @@ static struct record record = {
const char record_callchain_help[] = CALLCHAIN_RECORD_HELP
"\n\t\t\t\tDefault: fp";
+static bool dry_run;
+
/*
* XXX Will stay a global variable till we fix builtin-script.c to stop messing
* with it and switch to use the library functions in perf_evlist that came
@@ -1393,6 +1395,8 @@ struct option __record_options[] = {
"append timestamp to output filename"),
OPT_BOOLEAN(0, "switch-output", &record.switch_output,
"Switch output when receive SIGUSR2"),
+ OPT_BOOLEAN(0, "dry-run", &dry_run,
+ "Parse options then exit"),
OPT_END()
};
@@ -1462,6 +1466,9 @@ int cmd_record(int argc, const char **argv, const char *prefix __maybe_unused)
if (err)
return err;
+ if (dry_run)
+ return 0;
+
err = bpf__setup_stdout(rec->evlist);
if (err) {
bpf__strerror_setup_stdout(rec->evlist, err, errbuf, sizeof(errbuf));
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH 2/2] perf record: Add --dry-run option to check cmdline options Wang Nan <wangnan0@huawei.com> - 2016-06-16 10:10 +0200
Re: [PATCH 2/2] perf record: Add --dry-run option to check cmdline options Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-06-16 18:50 +0200
Re: [PATCH 2/2] perf record: Add --dry-run option to check cmdline options Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-06-16 19:00 +0200
Re: [PATCH 2/2] perf record: Add --dry-run option to check cmdline options "Wangnan (F)" <wangnan0@huawei.com> - 2016-06-20 05:40 +0200
Re: [PATCH 2/2] perf record: Add --dry-run option to check cmdline options Arnaldo Carvalho de Melo <acme@redhat.com> - 2016-06-20 16:40 +0200
Re: [PATCH 2/2] perf record: Add --dry-run option to check cmdline options Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2016-06-20 19:30 +0200
Re: [PATCH 2/2] perf record: Add --dry-run option to check cmdline options David Ahern <dsahern@gmail.com> - 2016-06-20 20:20 +0200
Re: [PATCH 2/2] perf record: Add --dry-run option to check cmdline options Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-06-20 21:40 +0200
Re: [PATCH 2/2] perf record: Add --dry-run option to check cmdline options Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-06-20 20:20 +0200
Re: [PATCH 2/2] perf record: Add --dry-run option to check cmdline options Namhyung Kim <namhyung@gmail.com> - 2016-06-21 04:10 +0200
Re: [PATCH 2/2] perf record: Add --dry-run option to check cmdline options David Ahern <dsahern@gmail.com> - 2016-06-21 04:50 +0200
Re: [PATCH 2/2] perf record: Add --dry-run option to check cmdline options "Wangnan (F)" <wangnan0@huawei.com> - 2016-06-21 08:30 +0200
perf cc/perf bpf was: Re: [PATCH 2/2] perf record: Add --dry-run option to check cmdline options Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-06-21 19:10 +0200
Re: [PATCH 2/2] perf record: Add --dry-run option to check cmdline options "Wangnan (F)" <wangnan0@huawei.com> - 2016-06-21 04:00 +0200
[tip:perf/core] perf record: Add --dry-run option to check cmdline options tip-bot for Wang Nan <tipbot@zytor.com> - 2016-06-22 10:40 +0200
csiph-web