Re: [PATCH 2/6] hid: intel_ish-hid: ISH Transport layer

From	One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/6] hid: intel_ish-hid: ISH Transport layer
Date	2016-06-20 16:30 +0200
Message-ID	<rM8n8-Wx-11@gated-at.bofh.it> (permalink)
References	<rIQ3n-2Yh-3@gated-at.bofh.it> <rIQ3n-2Yh-1@gated-at.bofh.it> <rL8Sd-2Y1-11@gated-at.bofh.it> <rL9lf-3mT-21@gated-at.bofh.it> <rM3Qu-6sw-53@gated-at.bofh.it>
Organization	Intel Corporation

Show all headers | View raw

On Mon, 20 Jun 2016 11:29:28 +0200 (CEST)
Jiri Kosina <jikos@kernel.org> wrote:

> On Fri, 17 Jun 2016, Srinivas Pandruvada wrote:
> 
> > > > +config INTEL_ISH_HID_TRANSPORT
> > > > +     bool
> > > > +     default n
> > > > +
> > > > +config INTEL_ISH_HID
> > > > +     bool "Intel Integrated Sensor Hub"  
> > > 
> > > Why can't the transport driver be built as a module?  
> > In current use case for PM, we don't want anyone to unload and
> > complain.  
> 
> Sorry, I don't understand this explanation, could you please elaborate?

If the driver isn't loaded your machine doesn't do power management.
There are a small set of drivers that need to be loaded to get pm even if
not using that device. ISH is one of them, and unlike the others not
sucked into a standard configuration.

If it's going to get loaded due to the presence of the PCI identifiers on
any normal distribution then it's in the same category as graphics and
ADSP based audio, both of which can be modules and the only real world
impact is they get loaded a second or two later during boot.

Alan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/6] hid: intel_ish-hid: ISH Transport layer Jiri Kosina <jikos@kernel.org> - 2016-06-17 22:50 +0200
  Re: [PATCH 2/6] hid: intel_ish-hid: ISH Transport layer Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2016-06-17 23:20 +0200
    Re: [PATCH 2/6] hid: intel_ish-hid: ISH Transport layer Jiri Kosina <jikos@kernel.org> - 2016-06-20 11:40 +0200
      Re: [PATCH 2/6] hid: intel_ish-hid: ISH Transport layer One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-06-20 16:30 +0200

csiph-web