Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1426669
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Tejun Heo <tj@kernel.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] mtip32xx: Remove deprecated create_workqueue |
| Date | Mon, 20 Jun 2016 17:10:01 +0200 |
| Message-ID | <rM8ZP-1ph-1@gated-at.bofh.it> (permalink) |
| References | <rLjNE-1CT-13@gated-at.bofh.it> |
| X-Original-To | Bhaktipriya Shridhar <bhaktipriya96@gmail.com> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=YY5Qacw4phmYRfePChv2n4xkaAQnKPoofx6ay/3e73E=; b=LqZOfWJQ8m8NNegGie6yRPJZ/Y1qN6wHu/b7JbyyoviIH9aA4fCgUUpwSLLszfVlaT FmATtqvs9tXPAjskLWegtE0HCGj6hLFp0YeHeBNzRWTBJ3WrOQf8AguNmzuIPp8s78TA Mbdp7KlaWTeTiIpUsat63eDiOMK07QW3LxdFiiTEOMi3CUhJ/BNg511+nRt+muDdfWCZ oeqKPuJOoR2E6bLOcXBfg8c5zgMtyPTZqs70D1exEE7L0Rg1FAuZ/hhI8tlsMLguf8vR 6wfe7OpFE4vocU/BBDXikGfAe7G1wZ0PS2z1IA62p41t88tVEl5VzpH/C7lv1mquLue+ Ls1w== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=YY5Qacw4phmYRfePChv2n4xkaAQnKPoofx6ay/3e73E=; b=b5sU0rp9sMxK6/BcPnrwpasdvMr77epvKmcVb2lJ6u8rV+rWMk5Wx5+RhIhZb++nfK sFX4dVqHcrE30KhyEODY+aPo0uzu+Yu5wWoG23OhbxEg9UfQgjPTdejS5juWwVfZBjg2 O1RqOoqHseqPFu9R/df3REQ6yK0ZhfFzPVwfWI8b7RmS5Wa8AJJsBHRAgkh6oBc9tiyL pkj+JnTOh9PBqkhELAQWxfrD7TLGh/w5RKzhbJjiuUcWat1mF4pzfEKdGSfpWBAtZfsZ OJ0eVjusQpG+Nt7aPnvzDCX5YH67a3NEgCHxR+X0Q+QBmA3Vs4vyRw1q29tszOqKUmM6 zJRg== |
| X-Gm-Message-State | ALyK8tKHDOAtGJ2He/OKGAYrDhbtceRcNxYv4pA3f2GvKjYJBbNUyyaX0bWXoxw0A6nWxQ== |
| X-Received | by 10.129.42.85 with SMTP id q82mr8354266ywq.280.1466434905909; Mon, 20 Jun 2016 08:01:45 -0700 (PDT) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.6.1 (2016-04-27) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 20 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Mon, 20 Jun 2016 11:01:44 -0400 |
| X-Original-Message-ID | <20160620150144.GU3262@mtj.duckdns.org> |
| X-Original-References | <20160618082205.GA6234@Karyakshetra> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1426669 |
Show key headers only | View raw
On Sat, Jun 18, 2016 at 01:52:05PM +0530, Bhaktipriya Shridhar wrote: > alloc_workqueue replaces deprecated create_workqueue(). > > A dedicated workqueue has been used since the workqueue isr_workq is > involved in irq handling path of block driver and requires forward > progress under memory pressure. Hence, WQ_MEM_RECLAIM has been set. > Since there are only a fixed number of work items, explicit concurrency > limit is unnecessary here. > > flush_workqueue is unnecessary since destroy_workqueue() itself calls > drain_workqueue() which flushes repeatedly till the workqueue > becomes empty. Hence the calls to flush_workqueue() before > destroy_workqueue() have been dropped. Looks good. Thanks! -- tejun
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] mtip32xx: Remove deprecated create_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-06-18 10:30 +0200
Re: [PATCH] mtip32xx: Remove deprecated create_workqueue Tejun Heo <tj@kernel.org> - 2016-06-20 17:10 +0200
Re: [PATCH] mtip32xx: Remove deprecated create_workqueue Tejun Heo <tj@kernel.org> - 2016-06-20 17:10 +0200
csiph-web