Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1426669

Re: [PATCH] mtip32xx: Remove deprecated create_workqueue

From Tejun Heo <tj@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] mtip32xx: Remove deprecated create_workqueue
Date 2016-06-20 17:10 +0200
Message-ID <rM8ZP-1ph-1@gated-at.bofh.it> (permalink)
References <rLjNE-1CT-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, Jun 18, 2016 at 01:52:05PM +0530, Bhaktipriya Shridhar wrote:
> alloc_workqueue replaces deprecated create_workqueue().
> 
> A dedicated workqueue has been used since the workqueue isr_workq is
> involved in irq handling path of block driver and requires forward
> progress under memory pressure. Hence, WQ_MEM_RECLAIM has been set.
> Since there are only a fixed number of work items, explicit concurrency
> limit is unnecessary here.
> 
> flush_workqueue is unnecessary since destroy_workqueue() itself calls
> drain_workqueue() which flushes repeatedly till the workqueue
> becomes empty. Hence the calls to flush_workqueue()  before
> destroy_workqueue() have been dropped.

Looks good.

Thanks!

-- 
tejun

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] mtip32xx: Remove deprecated create_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-06-18 10:30 +0200
  Re: [PATCH] mtip32xx: Remove deprecated create_workqueue Tejun Heo <tj@kernel.org> - 2016-06-20 17:10 +0200
    Re: [PATCH] mtip32xx: Remove deprecated create_workqueue Tejun Heo <tj@kernel.org> - 2016-06-20 17:10 +0200

csiph-web