Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1425871

Re: [PATCH 3/6] hwmon: (dell-smm) Disallow fan_type() calls on broken machines

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Pali Rohár <pali.rohar@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 3/6] hwmon: (dell-smm) Disallow fan_type() calls on broken machines
Date Sun, 19 Jun 2016 00:50:02 +0200
Message-ID <rLxdU-1O2-11@gated-at.bofh.it> (permalink)
References <rLaU1-4aG-3@gated-at.bofh.it> <rLaU1-4aG-21@gated-at.bofh.it> <rLuJ3-kK-11@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-transfer-encoding:message-id; bh=4R3312qSfh6bSscGHJuMDbJl4JS5JTatLLkGFXbr8T8=; b=UMA58dEkH49fgHLRXGBFLZ/BZdM01Ykd33HMj6rVOxsYeMxACDlQLrXPg0tqO4kBff aVDPH5BQBAuKNEi/ZuD3q/alD3ewrLgpHh8dvmb0XRcNO5ustHZjDFqFzaqdz+krvVdX yaS/0QYTjWKLIsogPQKCY+rstEDXiJ5tiJqau76qRXnJPPx53dzU2BH/MZ6i5PjUvZi/ z6Rms7A3nRNNcP/hgPDiSX9tZosgJo+1thmZr220YmPFHz/kMa8RGJWj4lnDfff19FAO 6Ph08xku4qNNKnCTf2I2b2wG+XlhcMzdDGHcoCH7SzhOjy9jDp1hz/4UfGUNrEuHP+23 NT9Q==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-transfer-encoding:message-id; bh=4R3312qSfh6bSscGHJuMDbJl4JS5JTatLLkGFXbr8T8=; b=CQ/5Rta5lZHZ+bguSvGOcq9wpt+ZXXHSOr/xrf9iOqqUY6OaAsNGWSBVeTFJS7Z3C6 t1ytRvOF2Swc2KtyoT0KvmIoRGa1wiC6BsT2llAd10CWvxZf91AmEBJfzPUPBeVxTVjj 6tKqJQAT/4jyTHBOP8Wzo35EpseFN9z5xECFfO5gaudlm2AcC0ddRZrtSxfndZYXbeEx +oG/qj5LYbuAmvia3wgNHO9dRTFom4rsrdAmtzcDYNxLXQN0kSZQ9P1mQmndA2M9n7xX ON5sZWRdOs17QrMUmz3Gt78/FP3+bLkrSQyFpQP0dUxw/8Le7C63RkRRX91m4u+VZwoj tm1w==
X-Gm-Message-State ALyK8tLOFXjpFI1jDgBwkYxPDUcjjdODd0B32AJNZBsGAiXuXe5DG5mQPJI29DryzveXcw==
X-Received by 10.194.79.198 with SMTP id l6mr7846961wjx.27.1466290018634; Sat, 18 Jun 2016 15:46:58 -0700 (PDT)
User-Agent KMail/1.13.7 (Linux/3.13.0-88-generic; KDE/4.14.2; x86_64; ; )
MIME-Version 1.0
Content-Type multipart/signed; boundary="nextPart5780907.ZJgZe51igl"; protocol="application/pgp-signature"; micalg=pgp-sha1
Content-Transfer-Encoding 7bit
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 54
Organization linux.* mail to news gateway
X-Original-Cc Jean Delvare <jdelvare@suse.com>, Jan C Peters <jcpeters89@gmail.com>, Thorsten Leemhuis <fedora@leemhuis.info>, David Santamaría Rogado <howl.nsp@gmail.com>, Peter Saunderson <peteasa@gmail.com>, Tolga Cakir <cevelnet@gmail.com>, "Austin S. Hemmelgarn" <ahferroin7@gmail.com>, Mario_Limonciello@dell.com, Gabriele Mazzotta <gabriele.mzt@gmail.com>, Michał Kępień <kernel@kempniu.pl>, Dakota Whipple <dakotajaywhipple@gmail.com>, Leon Yu <leon@leonyu.net>, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date Sun, 19 Jun 2016 00:46:57 +0200
X-Original-Message-ID <201606190046.57390@pali>
X-Original-References <1466204089-17030-1-git-send-email-pali.rohar@gmail.com> <1466204089-17030-4-git-send-email-pali.rohar@gmail.com> <5765AA31.8010202@roeck-us.net>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1425871

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On Saturday 18 June 2016 22:08:17 Guenter Roeck wrote:
> On 06/17/2016 03:54 PM, Pali Rohár wrote:
> > Some Dell machines have especially broken SMM or BIOS which cause
> > that once fan_type() is called then CPU fan speed going randomly
> > up and down. And for fixing this behaviour reboot is required.
> > 
> > So this patch creates fan_type blacklist of affected Dell machines
> > and disallow fan_type() call on them to prevent that erratic
> > behaviour.
> > 
> > Old blacklist which disabled loading driver on some machines added
> > in commits a4b45b25f18d ("hwmon: (dell-smm) Blacklist Dell Studio
> > XPS 8100") and 6220f4ebd7b4 ("hwmon: (dell-smm) Blacklist Dell
> > Studio XPS 8000") were moved to FAN_TYPE blacklist.
> > 
> > Reported-by: Jan C Peters <jcpeters89@gmail.com>
> > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=100121
> > Cc: stable@vger.kernel.org # v4.0+, will need backport
> 
> Applied.
> 
> It seemed worthwhile to apply this patch now, without waiting for
> further test feedback, since it at least reduces the impact of the
> observed problems. If follow-up changes are necessary, those will
> have to be applied in separate patches.
> 
> Guenter

Ok. Meanwhile patch was tested on Inspiron 580, so maybe it could be 
appended into commit message.

-- 
Pali Rohár
pali.rohar@gmail.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] dell-smm-hwmon fixes Pali Rohár <pali.rohar@gmail.com> - 2016-06-18 01:00 +0200
  [PATCH 5/6] hwmon: (dell-smm) Detect fan with index=2 Pali Rohár <pali.rohar@gmail.com> - 2016-06-18 01:00 +0200
    Re: [PATCH 5/6] hwmon: (dell-smm) Detect fan with index=2 Tolga Cakir <cevelnet@gmail.com> - 2016-06-19 02:10 +0200
  [PATCH 4/6] hwmon: (dell-smm) Cache fan_type() calls and change fan detection Pali Rohár <pali.rohar@gmail.com> - 2016-06-18 01:00 +0200
    Re: [PATCH 4/6] hwmon: (dell-smm) Cache fan_type() calls and change  fan detection Tolga Cakir <cevelnet@gmail.com> - 2016-06-19 02:10 +0200
  [PATCH 1/6] hwmon: (dell-smm) Fail in ioctl I8K_BIOS_VERSION when bios version is not a number Pali Rohár <pali.rohar@gmail.com> - 2016-06-18 01:00 +0200
    Re: [PATCH 1/6] hwmon: (dell-smm) Fail in ioctl I8K_BIOS_VERSION when  bios version is not a number Guenter Roeck <linux@roeck-us.net> - 2016-06-18 22:10 +0200
  [PATCH 3/6] hwmon: (dell-smm) Disallow fan_type() calls on broken machines Pali Rohár <pali.rohar@gmail.com> - 2016-06-18 01:00 +0200
    Re: [PATCH 3/6] hwmon: (dell-smm) Disallow fan_type() calls on broken  machines Guenter Roeck <linux@roeck-us.net> - 2016-06-18 22:10 +0200
      Re: [PATCH 3/6] hwmon: (dell-smm) Disallow fan_type() calls on broken machines Pali Rohár <pali.rohar@gmail.com> - 2016-06-19 00:50 +0200
  [PATCH 2/6] hwmon: (dell-smm) Restrict fan control and serial number to CAP_SYS_ADMIN by default Pali Rohár <pali.rohar@gmail.com> - 2016-06-18 01:00 +0200
    Re: [PATCH 2/6] hwmon: (dell-smm) Restrict fan control and serial  number to CAP_SYS_ADMIN by default Guenter Roeck <linux@roeck-us.net> - 2016-06-18 22:10 +0200
  [PATCH 6/6] hwmon: (dell-smm) In debug mode log duration of SMM calls Pali Rohár <pali.rohar@gmail.com> - 2016-06-18 01:00 +0200
  Re: [PATCH 0/6] dell-smm-hwmon fixes Pali Rohár <pali.rohar@gmail.com> - 2016-06-18 14:30 +0200
  Re: [PATCH 0/6] dell-smm-hwmon fixes Guenter Roeck <linux@roeck-us.net> - 2016-06-18 17:20 +0200
    Re: [PATCH 0/6] dell-smm-hwmon fixes Pali Rohár <pali.rohar@gmail.com> - 2016-06-18 17:30 +0200
      Re: [PATCH 0/6] dell-smm-hwmon fixes Guenter Roeck <linux@roeck-us.net> - 2016-06-18 19:00 +0200
        Re: [PATCH 0/6] dell-smm-hwmon fixes Pali Rohár <pali.rohar@gmail.com> - 2016-06-19 00:40 +0200
          Re: [PATCH 0/6] dell-smm-hwmon fixes Pali Rohár <pali.rohar@gmail.com> - 2016-06-20 11:20 +0200
            Re: [PATCH 0/6] dell-smm-hwmon fixes Guenter Roeck <linux@roeck-us.net> - 2016-06-20 15:30 +0200
              Re: [PATCH 0/6] dell-smm-hwmon fixes Pali Rohár <pali.rohar@gmail.com> - 2016-06-23 14:20 +0200
                Re: [PATCH 0/6] dell-smm-hwmon fixes Guenter Roeck <linux@roeck-us.net> - 2016-06-23 16:00 +0200
        Re: [PATCH 0/6] dell-smm-hwmon fixes Pali Rohár <pali.rohar@gmail.com> - 2016-06-19 00:50 +0200
  Re: [PATCH 0/6] dell-smm-hwmon fixes Michał Kępień <kernel@kempniu.pl> - 2016-06-22 10:10 +0200

csiph-web