Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From: Pali =?utf-8?q?Roh=C3=A1r?= <pali.rohar@gmail.com>
Newsgroups: linux.kernel
Subject: Re: [PATCH 3/6] hwmon: (dell-smm) Disallow fan_type() calls on broken machines
Date: Sun, 19 Jun 2016 00:50:02 +0200
Message-ID: <rLxdU-1O2-11@gated-at.bofh.it>
References: <rLaU1-4aG-3@gated-at.bofh.it> <rLaU1-4aG-21@gated-at.bofh.it> <rLuJ3-kK-11@gated-at.bofh.it>
User-Agent: KMail/1.13.7 (Linux/3.13.0-88-generic; KDE/4.14.2; x86_64; ; )
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart5780907.ZJgZe51igl"; protocol="application/pgp-signature"; micalg=pgp-sha1
Content-Transfer-Encoding: 7bit
Sender: robomod@news.nic.it
Approved: robomod@news.nic.it
Lines: 54
Organization: linux.* mail to news gateway
Xref: csiph.com linux.kernel:1425871

--nextPart5780907.ZJgZe51igl
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Saturday 18 June 2016 22:08:17 Guenter Roeck wrote:
> On 06/17/2016 03:54 PM, Pali Roh=C3=A1r wrote:
> > Some Dell machines have especially broken SMM or BIOS which cause
> > that once fan_type() is called then CPU fan speed going randomly
> > up and down. And for fixing this behaviour reboot is required.
> >=20
> > So this patch creates fan_type blacklist of affected Dell machines
> > and disallow fan_type() call on them to prevent that erratic
> > behaviour.
> >=20
> > Old blacklist which disabled loading driver on some machines added
> > in commits a4b45b25f18d ("hwmon: (dell-smm) Blacklist Dell Studio
> > XPS 8100") and 6220f4ebd7b4 ("hwmon: (dell-smm) Blacklist Dell
> > Studio XPS 8000") were moved to FAN_TYPE blacklist.
> >=20
> > Reported-by: Jan C Peters <jcpeters89@gmail.com>
> > Signed-off-by: Pali Roh=C3=A1r <pali.rohar@gmail.com>
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=3D100121
> > Cc: stable@vger.kernel.org # v4.0+, will need backport
>=20
> Applied.
>=20
> It seemed worthwhile to apply this patch now, without waiting for
> further test feedback, since it at least reduces the impact of the
> observed problems. If follow-up changes are necessary, those will
> have to be applied in separate patches.
>=20
> Guenter

Ok. Meanwhile patch was tested on Inspiron 580, so maybe it could be=20
appended into commit message.

=2D-=20
Pali Roh=C3=A1r
pali.rohar@gmail.com

--nextPart5780907.ZJgZe51igl
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEABECAAYFAldlz2EACgkQi/DJPQPkQ1L/DACfX7tv009c7ameStDyxCMQ4Vgt
soEAoKiElMAmQXNm0aWVj0/OciWW1q1W
=XEeL
-----END PGP SIGNATURE-----

--nextPart5780907.ZJgZe51igl--