[PATCH 1/1] staging: iio: initialize data pointer before using it

From	Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Newsgroups	linux.kernel
Subject	[PATCH 1/1] staging: iio: initialize data pointer before using it
Date	2016-06-18 23:20 +0200
Message-ID	<rLvON-113-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

ad7606_spi_read_block() reads SPI big-endian data into a buffer which is
then converted to CPU byte-order with a second variable.  This variable,
data, has been left unitialized after commit 87787e5ef727 ("Staging:
iio: Fix sparse endian warning").

Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Fixes: 87787e5ef727 ("Staging: iio: Fix sparse endian warning")
---
 drivers/staging/iio/adc/ad7606_spi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/adc/ad7606_spi.c b/drivers/staging/iio/adc/ad7606_spi.c
index 825da0769936..9587fa86dc69 100644
--- a/drivers/staging/iio/adc/ad7606_spi.c
+++ b/drivers/staging/iio/adc/ad7606_spi.c
@@ -21,7 +21,7 @@ static int ad7606_spi_read_block(struct device *dev,
 {
 	struct spi_device *spi = to_spi_device(dev);
 	int i, ret;
-	unsigned short *data;
+	unsigned short *data = buf;
 	__be16 *bdata = buf;
 
 	ret = spi_read(spi, buf, count * 2);
-- 
2.8.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] staging: iio: initialize data pointer before using it Nicolas Iooss <nicolas.iooss_linux@m4x.org> - 2016-06-18 23:20 +0200
  Re: [PATCH 1/1] staging: iio: initialize data pointer before using it Lars-Peter Clausen <lars@metafoo.de> - 2016-06-19 11:50 +0200
    Re: [PATCH 1/1] staging: iio: initialize data pointer before using it Nicolas Iooss <nicolas.iooss_linux@m4x.org> - 2016-06-19 12:10 +0200
      Re: [PATCH 1/1] staging: iio: initialize data pointer before using it Jonathan Cameron <jic23@kernel.org> - 2016-06-19 14:00 +0200

csiph-web