Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1425809

Re: [PATCH v2 04/11] mmc: sdhci-of-arasan: Properly set corecfg_baseclkfreq on rk3399

Show all headers | View raw

Am Montag, 13. Juni 2016, 16:04:28 schrieb Douglas Anderson:
> In the the earlier change in this series ("Documentation: mmc:
> sdhci-of-arasan: Add soc-ctl-syscon for corecfg regs") we can see the
> mechansim for specifying a syscon to properly set corecfg registers in
> sdhci-of-arasan.  Now let's use this mechanism to properly set
> corecfg_baseclkfreq on rk3399.
> 
> From [1] the corecfg_baseclkfreq is supposed to be set to:
>   Base Clock Frequency for SD Clock.
>   This is the frequency of the xin_clk.
> 
> This is a relatively easy thing to do.  Note that we assume that xin_clk
> is not dynamic and we can check the clock at probe time.  If any real
> devices have a dynamic xin_clk future patches could register for
> notifiers for the clock.
> 
> At the moment, setting corecfg_baseclkfreq is only supported for rk3399
> since we need a specific map for each implementation.  The code is
> written in a generic way that should make this easy to extend to other
> SoCs.  Note that a specific compatible string for rk3399 is already in
> use and so we add that to the table to match rk3399.
> 
> [1]:
> https://arasan.com/wp-content/media/eMMC-5-1-Total-Solution_Rev-1-3.pdf
> 
> Signed-off-by: Douglas Anderson <dianders@chromium.org>

this looks nice and versatile for other socs hopefully using that in the 
future.

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/11] Changes to support 150 MHz eMMC on rk3399 Douglas Anderson <dianders@chromium.org> - 2016-06-14 01:10 +0200
  [PATCH v2 11/11] arm64: dts: rockchip: Provide emmcclk to PHY for rk3399 Douglas Anderson <dianders@chromium.org> - 2016-06-14 01:10 +0200
    Re: [PATCH v2 11/11] arm64: dts: rockchip: Provide emmcclk to PHY for rk3399 Heiko Stübner <heiko@sntech.de> - 2016-06-18 14:10 +0200
  [PATCH v2 04/11] mmc: sdhci-of-arasan: Properly set corecfg_baseclkfreq on rk3399 Douglas Anderson <dianders@chromium.org> - 2016-06-14 01:10 +0200
    Re: [PATCH v2 04/11] mmc: sdhci-of-arasan: Properly set corecfg_baseclkfreq on rk3399 Heiko Stuebner <heiko@sntech.de> - 2016-06-18 20:10 +0200
  [PATCH v2 07/11] mmc: sdhci-of-arasan: Add ability to export card clock Douglas Anderson <dianders@chromium.org> - 2016-06-14 01:10 +0200
    Re: [PATCH v2 07/11] mmc: sdhci-of-arasan: Add ability to export card clock Doug Anderson <dianders@chromium.org> - 2016-06-15 18:50 +0200
  [PATCH v2 08/11] Documentation: phy: Let the rockchip eMMC PHY get an exported card clock Douglas Anderson <dianders@chromium.org> - 2016-06-14 01:10 +0200
    Re: [PATCH v2 08/11] Documentation: phy: Let the rockchip eMMC PHY  get an exported card clock Rob Herring <robh@kernel.org> - 2016-06-16 20:50 +0200
    Re: [PATCH v2 08/11] Documentation: phy: Let the rockchip eMMC PHY get an exported card clock Heiko Stübner <heiko@sntech.de> - 2016-06-18 23:50 +0200
    Re: [PATCH v2 08/11] Documentation: phy: Let the rockchip eMMC PHY  get an exported card clock Kishon Vijay Abraham I <kishon@ti.com> - 2016-06-20 15:10 +0200
  [PATCH v2 09/11] phy: rockchip-emmc: Minor code cleanup in rockchip_emmc_phy_power_on/off() Douglas Anderson <dianders@chromium.org> - 2016-06-14 01:10 +0200
    Re: [PATCH v2 09/11] phy: rockchip-emmc: Minor code cleanup in  rockchip_emmc_phy_power_on/off() Shawn Lin <shawn.lin@rock-chips.com> - 2016-06-14 02:40 +0200
  [PATCH v2 06/11] Documentation: mmc: sdhci-of-arasan: Add ability to export card clock Douglas Anderson <dianders@chromium.org> - 2016-06-14 01:10 +0200
    Re: [PATCH v2 06/11] Documentation: mmc: sdhci-of-arasan: Add ability to export card clock Heiko Stuebner <heiko@sntech.de> - 2016-06-18 20:10 +0200
  [PATCH v2 01/11] phy: rockchip-emmc: Increase lock time allowance Douglas Anderson <dianders@chromium.org> - 2016-06-14 01:20 +0200
    Re: [PATCH v2 01/11] phy: rockchip-emmc: Increase lock time allowance Shawn Lin <shawn.lin@rock-chips.com> - 2016-06-14 02:30 +0200
  [PATCH v2 03/11] Documentation: mmc: sdhci-of-arasan: Add soc-ctl-syscon for corecfg regs Douglas Anderson <dianders@chromium.org> - 2016-06-14 01:20 +0200
    Re: [PATCH v2 03/11] Documentation: mmc: sdhci-of-arasan: Add  soc-ctl-syscon for corecfg regs Shawn Lin <shawn.lin@rock-chips.com> - 2016-06-14 02:40 +0200
    Re: [PATCH v2 03/11] Documentation: mmc: sdhci-of-arasan: Add soc-ctl-syscon for corecfg regs Heiko Stübner <heiko@sntech.de> - 2016-06-18 16:20 +0200
  Re: [PATCH v2 0/11] Changes to support 150 MHz eMMC on rk3399 Heiko Stuebner <heiko@sntech.de> - 2016-06-17 01:50 +0200
  Re: [PATCH v2 0/11] Changes to support 150 MHz eMMC on rk3399 Kishon Vijay Abraham I <kishon@ti.com> - 2016-06-17 14:50 +0200
    Re: [PATCH v2 0/11] Changes to support 150 MHz eMMC on rk3399 Doug Anderson <dianders@chromium.org> - 2016-06-17 17:40 +0200

csiph-web