Re: [PATCH 1/1] v4l: Add camera voice coil lens control class, current control

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] v4l: Add camera voice coil lens control class, current control
Date	Sat, 18 Jun 2016 00:40:01 +0200
Message-ID	<rLaAF-447-15@gated-at.bofh.it> (permalink)
References	<rDx1o-8ea-11@gated-at.bofh.it> <rJlqz-5ve-59@gated-at.bofh.it> <rLahk-3W9-19@gated-at.bofh.it>
User-Agent	KMail/4.14.10 (Linux/4.4.6-gentoo; KDE/4.14.16; x86_64; ; )
MIME-Version	1.0
Content-Transfer-Encoding	7Bit
Content-Type	text/plain; charset="us-ascii"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	38
Organization	linux.* mail to news gateway
X-Original-Cc	Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>, Sakari Ailus <sakari.ailus@linux.intel.com>, pali.rohar@gmail.com, sre@kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, hverkuil@xs4all.nl, Sakari Ailus <sakari.ailus@iki.fi>
X-Original-Date	Sat, 18 Jun 2016 01:39:58 +0300
X-Original-Message-ID	<1475378.4YrS70O1yW@avalon>
X-Original-References	<20160527205140.GA26767@amd> <575DD89F.20607@gmail.com> <20160617221149.GB31380@amd>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1425530

Show key headers only | View raw

Hello,

On Saturday 18 Jun 2016 00:11:49 Pavel Machek wrote:
> Hi!
> 
> >> I also don't think the FOCUS_ABSOLUTE controls is a really good one for
> >> the voice coil lens current. I expect more voice coil lens controls
> >> (linear vs. PWM mode, ringing compensation...) to be needed so I think
> >> it's worth a new class.
> 
> Well, I do agree that that the new class is fine (and have no problem
> with your proposal), but I'd like to understand why FOCUS_ABSOLUTE is
> unsuitable. I'm actually thinking about writing very simple userspace
> camera, without autofocus, where user would just select
> "infinity"/"1m"/"50cm" ... and for that FOCUS_ABSOLUTE is equivalent
> to VOICE_COIL_CURRENT...
> 
> > Right, I still think movement mode should be standard control :)
> 
> What options would you like to see for movement mode?

I've discussed this with Sakari offline a few days ago. I won't nack this 
patch, but to ack it I'd like to have a better understanding of the big 
picture when it comes to focus and lens control. The proposed new control can 
make sense when taken in isolation, but I can't tell whether it still would 
when associated with the other controls that would be needed to properly 
control a voice coil lens.

If someone has analyzed the existing voice coil lens controllers and could 
share the result, in term of what parameters need to be controlled by the 
system and how they should be controlled, that would be very appreciated. Even 
better would be a real userspace implementation of a voice coil lens control 
algorithm.

-- 
Regards,

Laurent Pinchart

Thread

[PATCH 1/1] v4l: Add camera voice coil lens control class, current control Sakari Ailus <sakari.ailus@linux.intel.com> - 2016-06-12 22:50 +0200
  Re: [PATCH 1/1] v4l: Add camera voice coil lens control class,  current control Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-06-12 23:50 +0200
    Re: [PATCH 1/1] v4l: Add camera voice coil lens control class,  current control Pavel Machek <pavel@ucw.cz> - 2016-06-18 00:20 +0200
      Re: [PATCH 1/1] v4l: Add camera voice coil lens control class, current control Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-06-18 00:40 +0200
        Re: [PATCH 1/1] v4l: Add camera voice coil lens control class,  current control Pavel Machek <pavel@ucw.cz> - 2016-06-18 13:30 +0200
  Re: [PATCH 1/1] v4l: Add camera voice coil lens control class,  current control Pavel Machek <pavel@ucw.cz> - 2016-06-18 00:10 +0200

csiph-web