Re: [BUG] act_ife: sleeping functions called in atomic context

From	Cong Wang <xiyou.wangcong@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [BUG] act_ife: sleeping functions called in atomic context
Date	2016-06-17 19:20 +0200
Message-ID	<rL5AZ-W1-3@gated-at.bofh.it> (permalink)
References	(1 earlier) <rKNkK-5aq-39@gated-at.bofh.it> <rKPZf-7Fj-29@gated-at.bofh.it> <rKRy2-ov-13@gated-at.bofh.it> <rKUFA-2px-43@gated-at.bofh.it> <rKZOV-5LU-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jun 17, 2016 at 4:05 AM, Alexey Khoroshilov
<khoroshilov@ispras.ru> wrote:
> On 17.06.2016 08:38, Cong Wang wrote:
>> On Thu, Jun 16, 2016 at 7:14 PM, Cong Wang <xiyou.wangcong@gmail.com> wrote:
>>>
>>> I think we can just remove that tcf_lock, I am testing a patch now.
>>
>> Please try the attached patch, I will do more tests tomorrow.
>>
>> Thanks!
>>
>
> Looks good with two notes:
> 1. add_metainfo() still contains
> ret = ops->alloc(mi, metaval);
> that allocates memory with GFP_KERNEL.
> So, I would add gfpflag argument to alloc() operation.

I thought about this too, but we just allocate 32+ bytes here,
not sure if it is really worth to pass a gfp flag.

>
> 2. It makes sense to mention ife_mod_lock in the comment before
> add_metainfo(), because ife_mod_lock is the reason to use GFP_ATOMIC there.

Don't worry, it is in a separated patch, I will explain this
in the changelog. (I sent a combined patch just for review/tests.)

Thanks!

Thread

[BUG] act_ife: sleeping functions called in atomic context Alexey Khoroshilov <khoroshilov@ispras.ru> - 2016-06-16 23:00 +0200
  Re: [BUG] act_ife: sleeping functions called in atomic context Cong Wang <xiyou.wangcong@gmail.com> - 2016-06-16 23:50 +0200
    Re: [BUG] act_ife: sleeping functions called in atomic context Jamal Hadi Salim <jhs@mojatatu.com> - 2016-06-17 02:40 +0200
      Re: [BUG] act_ife: sleeping functions called in atomic context Cong Wang <xiyou.wangcong@gmail.com> - 2016-06-17 04:20 +0200
        Re: [BUG] act_ife: sleeping functions called in atomic context Cong Wang <xiyou.wangcong@gmail.com> - 2016-06-17 07:40 +0200
          Re: [BUG] act_ife: sleeping functions called in atomic context Alexey Khoroshilov <khoroshilov@ispras.ru> - 2016-06-17 13:10 +0200
            Re: [BUG] act_ife: sleeping functions called in atomic context Cong Wang <xiyou.wangcong@gmail.com> - 2016-06-17 19:20 +0200
          Re: [BUG] act_ife: sleeping functions called in atomic context Jamal Hadi Salim <jhs@mojatatu.com> - 2016-06-17 13:10 +0200
            Re: [BUG] act_ife: sleeping functions called in atomic context Cong Wang <xiyou.wangcong@gmail.com> - 2016-06-17 19:40 +0200
              Re: [BUG] act_ife: sleeping functions called in atomic context Jamal Hadi Salim <jhs@mojatatu.com> - 2016-06-18 16:50 +0200

csiph-web