Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1423473
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] rtlwifi: use s8 instead of char |
| Date | 2016-06-15 23:40 +0200 |
| Message-ID | <rKqHw-7SL-35@gated-at.bofh.it> (permalink) |
| References | <rKqet-7EL-13@gated-at.bofh.it> <rKqoa-7Kt-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wednesday, June 15, 2016 5:10:51 PM CEST Jes Sorensen wrote: > > Arnd, > > rtlwifi and rtl8xxxu are two distinct drivers managed by different > people. I'd be really nice if you could split this into a per driver > patch. > > That said, the use of char in rtl8xxxu is all as a flag indicator, so I > don't think the s/char/s8/ conversion is justified. I used char rather > than ugly bool to reduce the size of the struct. Makes sense, I'll resend without that change. If anything, the flag should become u8, not s8 anyway. Arnd
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH] rtlwifi: use s8 instead of char Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-06-15 23:20 +0200
Re: [PATCH] rtlwifi: use s8 instead of char Arnd Bergmann <arnd@arndb.de> - 2016-06-15 23:40 +0200
RE: [PATCH] rtlwifi: use s8 instead of char David Laight <David.Laight@ACULAB.COM> - 2016-06-16 18:10 +0200
Re: [PATCH] rtlwifi: use s8 instead of char Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-06-16 18:10 +0200
csiph-web