Re: [PATCH v3 10/10] ntb_perf: clear link_is_up flag when the link goes down.

From	"Jiang, Dave" <dave.jiang@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 10/10] ntb_perf: clear link_is_up flag when the link goes down.
Date	2016-06-15 23:40 +0200
Message-ID	<rKqHw-7SL-25@gated-at.bofh.it> (permalink)
References	<rKqHw-7SL-27@gated-at.bofh.it> <rKqHw-7SL-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2016-06-15 at 15:26 -0600, Logan Gunthorpe wrote:
> When the link goes down, the link_is_up flag did not return to
> false. This could have caused some subtle corner case bugs
> when the link goes up and down quickly.
> 
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>

Acked-by: Dave Jiang <dave.jiang@intel.com>

And all the other ntb_perf patches since there were no additional
changes. 

> ---
>  drivers/ntb/test/ntb_perf.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/ntb/test/ntb_perf.c
> b/drivers/ntb/test/ntb_perf.c
> index f0784e5..ae9d1b2 100644
> --- a/drivers/ntb/test/ntb_perf.c
> +++ b/drivers/ntb/test/ntb_perf.c
> @@ -557,6 +557,8 @@ static void perf_link_cleanup(struct work_struct
> *work)
>  
>  	if (!perf->link_is_up)
>  		cancel_delayed_work_sync(&perf->link_work);
> +
> +	perf->link_is_up = false;
>  }
>  
>  static int perf_setup_mw(struct ntb_dev *ntb, struct perf_ctx *perf)
> -- 
> 2.1.4
>

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 10/10] ntb_perf: clear link_is_up flag when the link  goes down. "Jiang, Dave" <dave.jiang@intel.com> - 2016-06-15 23:40 +0200
  Re: [PATCH v3 10/10] ntb_perf: clear link_is_up flag when the link  goes down. Logan Gunthorpe <logang@deltatee.com> - 2016-06-16 00:30 +0200
    Re: [PATCH v3 10/10] ntb_perf: clear link_is_up flag when the link  goes down. "Jiang, Dave" <dave.jiang@intel.com> - 2016-06-16 00:30 +0200
      Re: [PATCH v3 10/10] ntb_perf: clear link_is_up flag when the link  goes down. Logan Gunthorpe <logang@deltatee.com> - 2016-06-16 01:20 +0200

csiph-web