Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1423136

Re: [PATCH 3/5] clk: max77686: Add DT binding details for PMIC MAX77620

Show all headers | View raw

Hello Laxman,

On 06/15/2016 10:13 AM, Laxman Dewangan wrote:
> Maxim has used the same clock IP on multiple PMICs like
> MAX77686, MAX77802, MAX77620. Only differences are the
> number of clocks from these PMICs.
> 
> Add clock binding details and example for the max77620 in
> maxim,max77686.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> CC: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> CC: Javier Martinez Canillas <javier@dowhile0.org>
> ---
>  .../devicetree/bindings/clock/maxim,max77686.txt   | 38 +++++++++++++++++++---
>  include/dt-bindings/mfd/max77620.h                 |  4 +++

[snip]

> +		};
> diff --git a/include/dt-bindings/mfd/max77620.h b/include/dt-bindings/mfd/max77620.h
> index b911a07..e1bd08c 100644
> --- a/include/dt-bindings/mfd/max77620.h
> +++ b/include/dt-bindings/mfd/max77620.h
> @@ -36,4 +36,8 @@
>  #define MAX77620_FPS_SRC_NONE			3
>  #define MAX77620_FPS_SRC_DEF			4
>  
> +/* MAX77686 clocks */
> +#define MAX77620_CLKS_NUM			1
> +#define MAX77620_CLK_32K_OUT0			0
> +
>  #endif
> 

The clocks for the other Maxim PMICs define their clocks in the clock subdir
instead, so I wonder if include/dt-bindings/clock/maxim,max77620.h wouldn't
be better for consistency?

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] clk: Combine MAX77686 and MAX77802 driver and extend for MAX77620 Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-15 16:30 +0200
  [PATCH 1/5] clk: max77686: Combine Maxim max77686 and max77802 driver Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-15 16:30 +0200
    Re: [PATCH 1/5] clk: max77686: Combine Maxim max77686 and max77802  driver Javier Martinez Canillas <javier@osg.samsung.com> - 2016-06-15 17:20 +0200
    Re: [PATCH 1/5] clk: max77686: Combine Maxim max77686 and max77802  driver kbuild test robot <lkp@intel.com> - 2016-06-15 17:40 +0200
    [PATCH] clk: max77686: fix semicolon.cocci warnings kbuild test robot <lkp@intel.com> - 2016-06-15 17:40 +0200
    Re: [PATCH 1/5] clk: max77686: Combine Maxim max77686 and max77802  driver Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-16 11:40 +0200
    Re: [PATCH 1/5] clk: max77686: Combine Maxim max77686 and max77802  driver Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-16 15:10 +0200
  [PATCH 3/5] clk: max77686: Add DT binding details for PMIC MAX77620 Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-15 16:30 +0200
    Re: [PATCH 3/5] clk: max77686: Add DT binding details for PMIC  MAX77620 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-06-15 17:30 +0200
    Re: [PATCH 3/5] clk: max77686: Add DT binding details for PMIC MAX77620 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-16 11:50 +0200
  [PATCH 5/5] ARM: config: Get rid of config COMMON_CLK_MAX77802 Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-15 16:30 +0200
    Re: [PATCH 5/5] ARM: config: Get rid of config COMMON_CLK_MAX77802 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-06-15 17:40 +0200
      Re: [PATCH 5/5] ARM: config: Get rid of config COMMON_CLK_MAX77802 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-16 14:30 +0200
        Re: [PATCH 5/5] ARM: config: Get rid of config COMMON_CLK_MAX77802 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-06-16 15:10 +0200
          Re: [PATCH 5/5] ARM: config: Get rid of config COMMON_CLK_MAX77802 Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-16 15:30 +0200
  [PATCH 2/5] clk: Combine DT binding doc for max77686 and max77802 Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-15 16:30 +0200
    Re: [PATCH 2/5] clk: Combine DT binding doc for max77686 and max77802 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-06-15 17:20 +0200
      Re: [PATCH 2/5] clk: Combine DT binding doc for max77686 and max77802 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-16 11:40 +0200
    Re: [PATCH 2/5] clk: Combine DT binding doc for max77686 and max77802 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-16 11:50 +0200
  [PATCH 4/5] clk: max77686: Add support for MAX77620 clocks Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-15 16:30 +0200
    Re: [PATCH 4/5] clk: max77686: Add support for MAX77620 clocks Javier Martinez Canillas <javier@osg.samsung.com> - 2016-06-15 17:30 +0200
    Re: [PATCH 4/5] clk: max77686: Add support for MAX77620 clocks Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-16 12:00 +0200
      Re: [PATCH 4/5] clk: max77686: Add support for MAX77620 clocks Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-16 12:10 +0200
        Re: [PATCH 4/5] clk: max77686: Add support for MAX77620 clocks Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-16 12:20 +0200
    Re: [PATCH 4/5] clk: max77686: Add support for MAX77620 clocks Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-16 15:10 +0200

csiph-web